Mercurial > pidgin
diff src/gtkconv.c @ 12600:e856f985a0b9
[gaim-migrate @ 14934]
Enable the extra warnings regardless of --enable-debug.
Enable FORTIFY_SOURCE regardless of --enable-debug, adding a --disable-fortify flag to configure.
Enable (well, stop disabling) the missing initializer warnings.
This leads to warnings with: GValue v = {0,}; that must be worked around.
Basically, instead of:
GValue v = {0,};
...
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
We'd need to do:
GValue v;
...
v.g_type = 0;
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
Fix several cases of missing initializers. I don't think any of these are bugs, but having this warning seems like a good idea. It might prevent us from making a mistake in the future.
While I was fixing missing initializers, I optimized substitute_simple_word in plugins/spellchk.c, in the same way as I did substitute_word before. Yes, I'm bad for committing these together.
Added a --enable-fatal-asserts flag to configure. As the name implies, this makes g_return_... guards fatal. This is a useful flag to run on a debug copy of Gaim. It will make it very clear if your changes have triggered one of these guards. It's also useful in detecting g_return_... abuse, which helps prevent crashes if Gaim is compiled with G_DISABLE_ASSERT defined.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Wed, 21 Dec 2005 18:36:19 +0000 |
parents | 3d34460ecfd6 |
children | e63fb8e9f4ac |
line wrap: on
line diff
--- a/src/gtkconv.c Wed Dec 21 13:37:18 2005 +0000 +++ b/src/gtkconv.c Wed Dec 21 18:36:19 2005 +0000 @@ -2504,12 +2504,12 @@ static GtkItemFactoryEntry menu_items[] = { /* Conversation menu */ - { N_("/_Conversation"), NULL, NULL, 0, "<Branch>" }, + { N_("/_Conversation"), NULL, NULL, 0, "<Branch>", NULL }, { N_("/Conversation/New Instant _Message..."), "<CTL>M", menu_new_conv_cb, 0, "<StockItem>", GAIM_STOCK_IM }, - { "/Conversation/sep0", NULL, NULL, 0, "<Separator>" }, + { "/Conversation/sep0", NULL, NULL, 0, "<Separator>", NULL }, { N_("/Conversation/_Find..."), NULL, menu_find_cb, 0, "<StockItem>", GTK_STOCK_FIND }, @@ -2518,7 +2518,7 @@ "<StockItem>", GTK_STOCK_SAVE_AS }, { N_("/Conversation/Clea_r"), "<CTL>L", menu_clear_cb, 0, "<StockItem>", GTK_STOCK_CLEAR }, - { "/Conversation/sep1", NULL, NULL, 0, "<Separator>" }, + { "/Conversation/sep1", NULL, NULL, 0, "<Separator>", NULL }, { N_("/Conversation/Se_nd File..."), NULL, menu_send_file_cb, 0, "<StockItem>", GAIM_STOCK_FILE_TRANSFER }, { N_("/Conversation/Add Buddy _Pounce..."), NULL, menu_add_pounce_cb, @@ -2528,7 +2528,7 @@ { N_("/Conversation/In_vite..."), NULL, menu_invite_cb, 0, "<StockItem>", GAIM_STOCK_INVITE }, - { "/Conversation/sep2", NULL, NULL, 0, "<Separator>" }, + { "/Conversation/sep2", NULL, NULL, 0, "<Separator>", NULL }, { N_("/Conversation/Al_ias..."), NULL, menu_alias_cb, 0, "<StockItem>", GAIM_STOCK_EDIT }, @@ -2539,26 +2539,26 @@ { N_("/Conversation/_Remove..."), NULL, menu_add_remove_cb, 0, "<StockItem>", GTK_STOCK_REMOVE }, - { "/Conversation/sep3", NULL, NULL, 0, "<Separator>" }, + { "/Conversation/sep3", NULL, NULL, 0, "<Separator>", NULL }, { N_("/Conversation/Insert Lin_k..."), NULL, menu_insert_link_cb, 0, "<StockItem>", GAIM_STOCK_LINK }, { N_("/Conversation/Insert Imag_e..."), NULL, menu_insert_image_cb, 0, "<StockItem>", GAIM_STOCK_IMAGE }, - { "/Conversation/sep4", NULL, NULL, 0, "<Separator>" }, + { "/Conversation/sep4", NULL, NULL, 0, "<Separator>", NULL }, { N_("/Conversation/_Close"), NULL, menu_close_conv_cb, 0, "<StockItem>", GTK_STOCK_CLOSE }, /* Options */ - { N_("/_Options"), NULL, NULL, 0, "<Branch>" }, - { N_("/Options/Enable _Logging"), NULL, menu_logging_cb, 0, "<CheckItem>" }, - { N_("/Options/Enable _Sounds"), NULL, menu_sounds_cb, 0, "<CheckItem>" }, - { N_("/Options/Show Buddy _Icon"), NULL, menu_buddyicon_cb, 0, "<CheckItem>" }, - { "/Options/sep0", NULL, NULL, 0, "<Separator>" }, - { N_("/Options/Show Formatting _Toolbars"), NULL, menu_toolbar_cb, 0, "<CheckItem>" }, - { N_("/Options/Show Ti_mestamps"), "F2", menu_timestamps_cb, 0, "<CheckItem>" }, + { N_("/_Options"), NULL, NULL, 0, "<Branch>", NULL }, + { N_("/Options/Enable _Logging"), NULL, menu_logging_cb, 0, "<CheckItem>", NULL }, + { N_("/Options/Enable _Sounds"), NULL, menu_sounds_cb, 0, "<CheckItem>", NULL }, + { N_("/Options/Show Buddy _Icon"), NULL, menu_buddyicon_cb, 0, "<CheckItem>", NULL }, + { "/Options/sep0", NULL, NULL, 0, "<Separator>", NULL }, + { N_("/Options/Show Formatting _Toolbars"), NULL, menu_toolbar_cb, 0, "<CheckItem>", NULL }, + { N_("/Options/Show Ti_mestamps"), "F2", menu_timestamps_cb, 0, "<CheckItem>", NULL }, }; static const int menu_item_count =