diff src/gtkplugin.c @ 12600:e856f985a0b9

[gaim-migrate @ 14934] Enable the extra warnings regardless of --enable-debug. Enable FORTIFY_SOURCE regardless of --enable-debug, adding a --disable-fortify flag to configure. Enable (well, stop disabling) the missing initializer warnings. This leads to warnings with: GValue v = {0,}; that must be worked around. Basically, instead of: GValue v = {0,}; ... g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */ We'd need to do: GValue v; ... v.g_type = 0; g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */ Fix several cases of missing initializers. I don't think any of these are bugs, but having this warning seems like a good idea. It might prevent us from making a mistake in the future. While I was fixing missing initializers, I optimized substitute_simple_word in plugins/spellchk.c, in the same way as I did substitute_word before. Yes, I'm bad for committing these together. Added a --enable-fatal-asserts flag to configure. As the name implies, this makes g_return_... guards fatal. This is a useful flag to run on a debug copy of Gaim. It will make it very clear if your changes have triggered one of these guards. It's also useful in detecting g_return_... abuse, which helps prevent crashes if Gaim is compiled with G_DISABLE_ASSERT defined. committer: Tailor Script <[e-mail]>

--- a/src/gtkplugin.c	Wed Dec 21 13:37:18 2005 +0000
+++ b/src/gtkplugin.c	Wed Dec 21 18:36:19 2005 +0000
@@ -236,7 +236,7 @@
 {
 	gchar *buf, *pname, *pdesc, *pauth, *pweb;
 	GtkTreeIter  iter;
-	GValue val = { 0, };
+	GValue val;
 	GaimPlugin *plug;
 
 	if (!gtk_tree_selection_get_selected (sel, &model, &iter))
@@ -254,6 +254,7 @@
 
 	gtk_widget_set_sensitive(expander, TRUE);
 
+	val.g_type = 0;
 	gtk_tree_model_get_value (model, &iter, 2, &val);
 	plug = g_value_get_pointer(&val);
 
@@ -298,7 +299,7 @@
 	GaimPlugin *plug;
 	GtkWidget *dialog, *box;
 	GtkTreeModel *model;
-	GValue val = { 0, };
+	GValue val;
 	GtkTreeIter iter;
 
 	switch (response) {
@@ -314,7 +315,8 @@
 	case GAIM_RESPONSE_CONFIGURE:
 		if (! gtk_tree_selection_get_selected (sel, &model, &iter))
 			return;
-		gtk_tree_model_get_value (model, &iter, 2, &val);
+		val.g_type = 0;
+		gtk_tree_model_get_value(model, &iter, 2, &val);
 		plug = g_value_get_pointer(&val);
 		if (plug == NULL)
 			break;