Mercurial > pidgin
diff src/gtkprefs.c @ 12600:e856f985a0b9
[gaim-migrate @ 14934]
Enable the extra warnings regardless of --enable-debug.
Enable FORTIFY_SOURCE regardless of --enable-debug, adding a --disable-fortify flag to configure.
Enable (well, stop disabling) the missing initializer warnings.
This leads to warnings with: GValue v = {0,}; that must be worked around.
Basically, instead of:
GValue v = {0,};
...
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
We'd need to do:
GValue v;
...
v.g_type = 0;
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
Fix several cases of missing initializers. I don't think any of these are bugs, but having this warning seems like a good idea. It might prevent us from making a mistake in the future.
While I was fixing missing initializers, I optimized substitute_simple_word in plugins/spellchk.c, in the same way as I did substitute_word before. Yes, I'm bad for committing these together.
Added a --enable-fatal-asserts flag to configure. As the name implies, this makes g_return_... guards fatal. This is a useful flag to run on a debug copy of Gaim. It will make it very clear if your changes have triggered one of these guards. It's also useful in detecting g_return_... abuse, which helps prevent crashes if Gaim is compiled with G_DISABLE_ASSERT defined.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Wed, 21 Dec 2005 18:36:19 +0000 |
parents | 05b5e6c24ea7 |
children | 0124220c7575 |
line wrap: on
line diff
--- a/src/gtkprefs.c Wed Dec 21 13:37:18 2005 +0000 +++ b/src/gtkprefs.c Wed Dec 21 18:36:19 2005 +0000 @@ -366,7 +366,7 @@ GtkTreeIter iter; const char *themename; char *description; - GValue val = { 0, }; + GValue val; GtkTreePath *path, *oldpath; struct smiley_theme *new_theme, *old_theme; @@ -374,6 +374,7 @@ return; old_theme = current_smiley_theme; + val.g_type = 0; gtk_tree_model_get_value(model, &iter, 3, &val); path = gtk_tree_model_get_path(model, &iter); themename = g_value_get_string(&val); @@ -1430,12 +1431,14 @@ static void prefs_sound_sel(GtkTreeSelection *sel, GtkTreeModel *model) { GtkTreeIter iter; - GValue val = { 0, }; + GValue val; const char *file; char *pref; if (! gtk_tree_selection_get_selected (sel, &model, &iter)) return; + + val.g_type = 0; gtk_tree_model_get_value (model, &iter, 3, &val); sound_row_sel = g_value_get_uint(&val);