Mercurial > pidgin
diff src/gtkrequest.c @ 12600:e856f985a0b9
[gaim-migrate @ 14934]
Enable the extra warnings regardless of --enable-debug.
Enable FORTIFY_SOURCE regardless of --enable-debug, adding a --disable-fortify flag to configure.
Enable (well, stop disabling) the missing initializer warnings.
This leads to warnings with: GValue v = {0,}; that must be worked around.
Basically, instead of:
GValue v = {0,};
...
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
We'd need to do:
GValue v;
...
v.g_type = 0;
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
Fix several cases of missing initializers. I don't think any of these are bugs, but having this warning seems like a good idea. It might prevent us from making a mistake in the future.
While I was fixing missing initializers, I optimized substitute_simple_word in plugins/spellchk.c, in the same way as I did substitute_word before. Yes, I'm bad for committing these together.
Added a --enable-fatal-asserts flag to configure. As the name implies, this makes g_return_... guards fatal. This is a useful flag to run on a debug copy of Gaim. It will make it very clear if your changes have triggered one of these guards. It's also useful in detecting g_return_... abuse, which helps prevent crashes if Gaim is compiled with G_DISABLE_ASSERT defined.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Wed, 21 Dec 2005 18:36:19 +0000 |
parents | 255e6912607b |
children | 8765dee8f517 |
line wrap: on
line diff
--- a/src/gtkrequest.c Wed Dec 21 13:37:18 2005 +0000 +++ b/src/gtkrequest.c Wed Dec 21 18:36:19 2005 +0000 @@ -763,12 +763,13 @@ const gchar *key, GtkTreeIter *iter, gpointer user_data) { GtkTreeModel *model; - GValue val1 = { 0, }; - GValue val2 = { 0, }; + GValue val1; + GValue val2; const char *tmp; model = gtk_entry_completion_get_model (completion); + val1.g_type = 0; gtk_tree_model_get_value(model, iter, 2, &val1); tmp = g_value_get_string(&val1); if (tmp != NULL && gaim_str_has_prefix(tmp, key)) @@ -778,6 +779,7 @@ } g_value_unset(&val1); + val2.g_type = 0; gtk_tree_model_get_value(model, iter, 3, &val2); tmp = g_value_get_string(&val2); if (tmp != NULL && gaim_str_has_prefix(tmp, key)) @@ -793,11 +795,12 @@ static gboolean screenname_completion_match_selected_cb(GtkEntryCompletion *completion, GtkTreeModel *model, GtkTreeIter *iter, gpointer *user_data) { - GValue val = { 0, }; + GValue val; GaimRequestField *screen_field = user_data[1]; GList *fields = screen_field->group->fields; GaimAccount *account; + val.g_type = 0; gtk_tree_model_get_value(model, iter, 1, &val); gtk_entry_set_text(GTK_ENTRY(user_data[0]), g_value_get_string(&val)); g_value_unset(&val);