Mercurial > pidgin
diff src/gtkroomlist.c @ 12600:e856f985a0b9
[gaim-migrate @ 14934]
Enable the extra warnings regardless of --enable-debug.
Enable FORTIFY_SOURCE regardless of --enable-debug, adding a --disable-fortify flag to configure.
Enable (well, stop disabling) the missing initializer warnings.
This leads to warnings with: GValue v = {0,}; that must be worked around.
Basically, instead of:
GValue v = {0,};
...
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
We'd need to do:
GValue v;
...
v.g_type = 0;
g_value_init(&v, G_TYPE_FOO); /* or other use of the GValue */
Fix several cases of missing initializers. I don't think any of these are bugs, but having this warning seems like a good idea. It might prevent us from making a mistake in the future.
While I was fixing missing initializers, I optimized substitute_simple_word in plugins/spellchk.c, in the same way as I did substitute_word before. Yes, I'm bad for committing these together.
Added a --enable-fatal-asserts flag to configure. As the name implies, this makes g_return_... guards fatal. This is a useful flag to run on a debug copy of Gaim. It will make it very clear if your changes have triggered one of these guards. It's also useful in detecting g_return_... abuse, which helps prevent crashes if Gaim is compiled with G_DISABLE_ASSERT defined.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Wed, 21 Dec 2005 18:36:19 +0000 |
parents | 255e6912607b |
children | 82fd52867ffc |
line wrap: on
line diff
--- a/src/gtkroomlist.c Wed Dec 21 13:37:18 2005 +0000 +++ b/src/gtkroomlist.c Wed Dec 21 18:36:19 2005 +0000 @@ -166,7 +166,7 @@ static void selection_changed_cb(GtkTreeSelection *selection, GaimGtkRoomlist *grl) { GtkTreeIter iter; - GValue val = { 0, }; + GValue val; GaimRoomlistRoom *room; static struct _menu_cb_info *info; GaimGtkRoomlistDialog *dialog; @@ -174,6 +174,7 @@ dialog = grl->dialog; if (gtk_tree_selection_get_selected(selection, NULL, &iter)) { + val.g_type = 0; gtk_tree_model_get_value(GTK_TREE_MODEL(grl->model), &iter, ROOM_COLUMN, &val); room = g_value_get_pointer(&val); if (!room || !(room->type & GAIM_ROOMLIST_ROOMTYPE_ROOM)) { @@ -217,10 +218,11 @@ GaimGtkRoomlist *grl = list->ui_data; GtkTreeIter iter; GaimRoomlistRoom *room; - GValue val = { 0, }; + GValue val; struct _menu_cb_info info; gtk_tree_model_get_iter(GTK_TREE_MODEL(grl->model), &iter, path); + val.g_type = 0; gtk_tree_model_get_value(GTK_TREE_MODEL(grl->model), &iter, ROOM_COLUMN, &val); room = g_value_get_pointer(&val); if (!room || !(room->type & GAIM_ROOMLIST_ROOMTYPE_ROOM)) @@ -236,7 +238,7 @@ { GtkTreePath *path; GaimGtkRoomlist *grl = list->ui_data; - GValue val = { 0, }; + GValue val; GaimRoomlistRoom *room; GtkTreeIter iter; GtkWidget *menu; @@ -250,6 +252,7 @@ return FALSE; gtk_tree_model_get_iter(GTK_TREE_MODEL(grl->model), &iter, path); gtk_tree_path_free(path); + val.g_type = 0; gtk_tree_model_get_value (GTK_TREE_MODEL(grl->model), &iter, ROOM_COLUMN, &val); room = g_value_get_pointer(&val); @@ -275,8 +278,9 @@ { GaimRoomlist *list = user_data; GaimRoomlistRoom *category; - GValue val = { 0, }; + GValue val; + val.g_type = 0; gtk_tree_model_get_value(gtk_tree_view_get_model(treeview), arg1, ROOM_COLUMN, &val); category = g_value_get_pointer(&val);