Mercurial > pidgin
view AUTHORS @ 12233:02833a0ae716
[gaim-migrate @ 14535]
SF Patch #1367116 from Michael Carlson
"In profiling gaim, I noticed that on simply starting
CVS gaim, xmlnode_insert_child is using up by far the
most CPU time. After some testing, I realized the
reason why: xmlnode_insert_child is called some 18,000
times on startup, and it is inserting the child at the
end of the list each time, simply by traversing through
the entire linked list. Sometimes this list can have as
many as 800 elements.
This patch adds a variable to the _xmlnode struct,
lastchild, which simply keeps track of the last node in
the list of children. This is then used by
xmlnode_insert_child to insert at the end of the list,
instead of traversing through the whole list each time.
The two relevant functions in xmlnode.c that need to be
updated to keep track of this function appropriately
have been updated.
Running 3 times with and without the change, the
results from oprofile say it all. Here are the measured
number of clock cycles / % of total clock cycles /
function used to simply start and close gaim before the
change:
204 60.7143 xmlnode_insert_child
210 61.4035 xmlnode_insert_child
230 61.8280 xmlnode_insert_child
And after (note that one time no clock cycles were
caught at all)
3 2.5862 xmlnode_insert_child
3 2.5641 xmlnode_insert_child
This affects other areas of the program than just
starting up, but this seems to be the most noticeable
place."
Speed is good. As I was verifying this patch, I added some g_return_val_if_fail() checks.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Sun, 27 Nov 2005 03:42:39 +0000 |
| parents | 03ee9d7360a3 |
| children | 1c8ea8f3b84e |
line wrap: on
line source
gaim - the Pimpin' Penguin IM Clone that's Good for the Soul ============================================================ We've got an IRC room now too, #gaim on irc.freenode.net. Come check us out. Active Developers: ------------------ Sean Egan <bj91704@binghamton.edu> - Lead Developer AIM: SeanEgn ICQ: 96642211 MSN: SeanEgn@hotmail.com Yahoo: SeanEgn Jabber: SeanEgn@jabber.org Daniel 'datallah' Atallah Christian 'ChipX86' Hammond - Developer & Webmaster Herman 'Hermanator' Bloggs - Win32 Port Nathan 'faceprint' Walp - Developer Mark 'KingAnt' Doliner - Developer Ethan 'Paco-Paco' Blanton - Developer Tim 'marv' Ringenbach - Developer Luke 'LSchiere' Schierer - Support Etan 'deryni' Reisner - Developer Stu 'nosnilmot' Tomlinson - Developer Gary 'grim' Kramlich - Developer Richard 'rlaager' Laager Crazy Patch Writers: -------------------- Ka-Hing 'javabsp' Cheung Felipe 'shx' Contreras Decklin Foster Peter 'Bleeter' Lawler Robert 'Robot101' McQueen Benjamin Miller Kevin 'SimGuy' Stange Retired: -------- Rob Flynn <gaim@robflynn.com> - Former Maintainer Adam Fritzler - Former libfaim Maintainer Eric Warmenhoven <eric@warmenhoven.org> - Former Lead Developer Jim Duchek <jimduchek@ou.edu> - Former Maintainer Jim Seymour - Former Jabber Developer Mark Spencer <markster@marko.net> - Original Author Syd Logan - Hacker and Designated Driver (lazy bum)