Mercurial > pidgin
view README.CVS @ 12233:02833a0ae716
[gaim-migrate @ 14535]
SF Patch #1367116 from Michael Carlson
"In profiling gaim, I noticed that on simply starting
CVS gaim, xmlnode_insert_child is using up by far the
most CPU time. After some testing, I realized the
reason why: xmlnode_insert_child is called some 18,000
times on startup, and it is inserting the child at the
end of the list each time, simply by traversing through
the entire linked list. Sometimes this list can have as
many as 800 elements.
This patch adds a variable to the _xmlnode struct,
lastchild, which simply keeps track of the last node in
the list of children. This is then used by
xmlnode_insert_child to insert at the end of the list,
instead of traversing through the whole list each time.
The two relevant functions in xmlnode.c that need to be
updated to keep track of this function appropriately
have been updated.
Running 3 times with and without the change, the
results from oprofile say it all. Here are the measured
number of clock cycles / % of total clock cycles /
function used to simply start and close gaim before the
change:
204 60.7143 xmlnode_insert_child
210 61.4035 xmlnode_insert_child
230 61.8280 xmlnode_insert_child
And after (note that one time no clock cycles were
caught at all)
3 2.5862 xmlnode_insert_child
3 2.5641 xmlnode_insert_child
This affects other areas of the program than just
starting up, but this seems to be the most noticeable
place."
Speed is good. As I was verifying this patch, I added some g_return_val_if_fail() checks.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sun, 27 Nov 2005 03:42:39 +0000 |
parents | e4a27c9aec4c |
children |
line wrap: on
line source
If you plan to use gaim CVS, PLEASE read this message in its entirety! Gaim is a fast-moving project with a somewhat regular release schedule. Due to the rate of gaim development, CVS undergoes frequent bursts of massive changes, often leaving behind brokenness and partial functionality while the responsible developers rewrite some portion of code or seek to add new features. What this all boils down to is that CVS _WILL_ sometimes be broken. Because of this, we ask that users who are not interested in personally tracking down bugs and fixing them (without a lot of assistance from the developers!) avoid CVS and use releases. Since releases will be made often, this should not prevent anyone from using the newest, shiniest features -- but it will prevent users from having to deal with ugly development bugs that we already know about but haven't gotten around to fixing. If you are interested in hacking on gaim, please read README and HACKING, and take note of the issues in PROGRAMMING_NOTES. (Note that they may be somewhat out of date at times.) Win32 developers, please read README.mingw. By far the best documentation, however, is the documented code. Not all parts of gaim have yet been documented, but the major subsystems are falling fast. If you have doxygen, you can use the Doxyfile in the toplevel directory to generate pretty documentation. Otherwise (or even if you do!), the header files for each subsystem contain documentation for the functions they contain. For instance, conversation.h contains documentation for the entire gaim_conversation_* API, and account.h contains documentation for the gaim_account_* API. If you have questions, please feel free to contact the gaim developers by email at gaim-devel@lists.sourceforge.net, on IRC at irc.freenode.net in #gaim, or via the sourceforge forums at http://www.sourceforge.net/projects/gaim. Please do as much homework as you can before contacting us; the more you know about your question, the faster and more effectively we can help you! Send patches to gaim-devel@lists.sourceforge.net or post them in the Sourceforge forums at http://www.sourceforge.net/projects/gaim.