Mercurial > pidgin
view libpurple/protocols/oscar/AUTHORS @ 31588:06ed9020b784
jabber: Treat empty <group/> elements as "Buddies", not ""
This ultimately led to duplicates in the list, because
we had one entry in the GSList as "", and one as NULL, both of which are
invalid group names, which resulted in the core blithely replacing
them with "Buddies" and generating duplicates.
I've tested with and without, and can reproduce the issues without the change.
Log:
<item subscription='both' name='person' jid='person@example.com'><group></group><group></group></item>
(19:32:23) jabber: jabber_roster_parse(): Removing person@example.com from group 'Buddies' on the local list
(19:32:23) GLib: g_string_append: assertion `val != NULL' failed
(19:32:23) jabber: jabber_roster_parse(): Adding person@example.com to groups: ,
(19:32:23) g_log: purple_find_group: assertion `(name != NULL) && (*name != '\0')' failed
(19:32:23) g_log: purple_group_new: assertion `name != NULL' failed
(19:32:23) g_log: purple_blist_add_group: assertion `group != NULL' failed
(19:32:23) g_log: purple_find_group: assertion `(name != NULL) && (*name != '\0')' failed
(19:32:23) g_log: purple_group_new: assertion `*name != '\0'' failed
(19:32:23) g_log: purple_blist_add_group: assertion `group != NULL' failed
Since I had to look it up, purple_blist_add_buddy replaces (group == NULL) with "Buddies".
author | Paul Aurich <paul@darkrain42.org> |
---|---|
date | Wed, 11 May 2011 01:58:03 +0000 |
parents | e01a6dc25900 |
children |
line wrap: on
line source
N: ComBOTS Product GmbH (htfv) T: 2007 E: foss@combots.com N: Jonathan Clark T: 2005-2006 E: ardentlygnarley a.t users d.o.t sourceforge d.o.t net N: Mark Doliner T: 2001-2006 H: markdoliner E: thekingant a.t users d.o.t sourceforge d.o.t net W: http://kingant.net/ N: Adam Fritzler T: 1998-2001 H: mid E: mid a.t auk d.o.t cx W: http://www.auk.cx/~mid,http://www.auk.cx/faim D: Wrote most of the wap of crap that you see before you. N: Josh Myer T: 1998-2001 E: josh a.t joshisanerd d.o.t com D: OFT/ODC (not quite finished yet..), random little things, Munger-At-Large, compile-time warnings. N: Daniel M. Pomerantz H: dmprantz D: Made initial versions cross platform N: Daniel Reed T: 1998-2001 H: n, linuxkitty E: n a.t ml d.o.t org W: http://users.n.ml.org/n/ D: Fixed aim_snac.c N: Eric Warmenhoven T: 1998-2001 E: warmenhoven a.t linux d.o.t com D: Some OFT info, initial author of the libpurple-side of the oscar protocol plugin N: Brock Wilcox T: 1998-2001 H: awwaiid E: awwaiid a.t auk d.o.t cx D: Figured out original password roasting