Mercurial > pidgin
view src/debug.c @ 10789:0caa9827edf5
[gaim-migrate @ 12431]
" The following log snippets should explain it: " --rlaager
(20:24:00) rlaager: Regarding the signal handling
conversation the other day... I've written a patch to stop
calling signal handlers and return as soon as we find one
signal handler that returns TRUE to indicate that it's
handled the signal. Is this the right approach?
(20:24:22) Ethan Blanton (Paco-Paco): the trouble is that it's
documented to behave exactly the way it does
(20:24:31) Ethan Blanton (Paco-Paco): so changing it is
notbackwards compatible
(20:24:31) rlaager: I'm talking for HEAD.
(20:24:41) Ethan Blanton (Paco-Paco): oh, I think that's a
good approach, yes
(20:24:53) rlaager: The way I've described is how I
*expected* it to work, having not read the documentation.
(20:25:09) Ethan Blanton (Paco-Paco): I'm convinced
(20:27:04) Stu Tomlinson (nosnilmot): rlaager: this, I
assume, breaks the generic-ness of signals, by assuming
that any that return values return booleans?
(20:27:26) Ethan Blanton (Paco-Paco): please break it
(20:27:33) Ethan Blanton (Paco-Paco): we already have
out-parameters
(20:27:42) rlaager: nosnilmot: from what I can see, the
return type is handled as a (void *)... so I'm checking that
ret_value != NULL
(20:27:57) rlaager: nosnilmot: that's the correct way to do it,
right?
...
(20:29:01) Ethan Blanton (Paco-Paco): allowing a
meaningful return value is an over-engineering
(20:30:07) rlaager: even after this patch, you should be able
to return meaningful return values
(20:30:15) rlaager: it'll just short-circuit on the first handler
that does
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Thu, 07 Apr 2005 14:55:02 +0000 |
parents | 6a20307ef8dc |
children | 50224ac8184d |
line wrap: on
line source
/** * @file debug.c Debug API * @ingroup core * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #include "debug.h" #include "internal.h" #include "prefs.h" static GaimDebugUiOps *debug_ui_ops = NULL; /* * This determines whether debug info should be written to the * console or not. * * It doesn't make sense to make this a normal Gaim preference * because it's a command line option. This will always be FALSE, * unless the user explicitly started Gaim with the -d flag. * It doesn't matter what this value was the last time Gaim was * started, so it doesn't make sense to save it in prefs. */ static gboolean debug_enabled = FALSE; void gaim_debug_vargs(GaimDebugLevel level, const char *category, const char *format, va_list args) { GaimDebugUiOps *ops; g_return_if_fail(level != GAIM_DEBUG_ALL); g_return_if_fail(format != NULL); if (debug_enabled) { gchar *arg_s, *ts_s; arg_s = g_strdup_vprintf(format, args); if ((category != NULL) && (gaim_prefs_exists("/core/debug/timestamps")) && (gaim_prefs_get_bool("/core/debug/timestamps"))) { gchar mdate[64]; time_t mtime = time(NULL); strftime(mdate, sizeof(mdate), "%H:%M:%S", localtime(&mtime)); ts_s = g_strdup_printf("(%s) ", mdate); } else { ts_s = g_strdup(""); } if (category == NULL) g_print("%s%s", ts_s, arg_s); else g_print("%s%s: %s", ts_s, category, arg_s); g_free(arg_s); g_free(ts_s); } ops = gaim_debug_get_ui_ops(); if (ops != NULL && ops->print != NULL) ops->print(level, category, format, args); } void gaim_debug(GaimDebugLevel level, const char *category, const char *format, ...) { va_list args; g_return_if_fail(level != GAIM_DEBUG_ALL); g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(level, category, format, args); va_end(args); } void gaim_debug_misc(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_MISC, category, format, args); va_end(args); } void gaim_debug_info(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_INFO, category, format, args); va_end(args); } void gaim_debug_warning(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_WARNING, category, format, args); va_end(args); } void gaim_debug_error(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_ERROR, category, format, args); va_end(args); } void gaim_debug_fatal(const char *category, const char *format, ...) { va_list args; g_return_if_fail(format != NULL); va_start(args, format); gaim_debug_vargs(GAIM_DEBUG_FATAL, category, format, args); va_end(args); } void gaim_debug_set_enabled(gboolean enabled) { debug_enabled = enabled; } gboolean gaim_debug_is_enabled() { return debug_enabled; } void gaim_debug_set_ui_ops(GaimDebugUiOps *ops) { debug_ui_ops = ops; } GaimDebugUiOps * gaim_debug_get_ui_ops(void) { return debug_ui_ops; } void gaim_debug_init(void) { gaim_prefs_add_none("/core/debug"); /* * This pref is currently used by both the console * output and the debug window output. */ gaim_prefs_add_bool("/core/debug/timestamps", FALSE); }