Mercurial > pidgin
view pixmaps/gnome_add.xpm @ 5531:10920646988f
[gaim-migrate @ 5931]
Ambrose LI (acli) writes:
" This is w.r.t. the 0.64cvs as of around 20:25 EDT.
When gaim starts up, it displays the signon window, and
then immeidately segfaults. The problem is that
tobase64() in util.c uses a size_t (which could very
likely be unsigned) as a second parameter, but proxy.c
calls it with a -1. "
at my questioning the specific change he made:
"Actually the initialization is not the matter (just
something I did while debugging and did not remove, since it
makes sense in any case), it's the other change that matters.
In util.h, the javadoc-like comments states that passing len
= -1 means that tobase64() should calculated len =
strlen(buf). However, since size_t is (or can be) unsigned,
the "if (len < 0)" check never succeeds, so passing
-1
actually results in a very large integer being passed.
So the "if (len < 0)" check actually need to be
changed so
that the passed "-1" will actually get recognized."
so since most of us aren't segfaulting on start, i'm guessing this is a
platform/os specific problem, but that the change shouldn't affect the
rest of us anyway.
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Mon, 26 May 2003 12:45:05 +0000 |
| parents | ff7a04b30608 |
| children |
line wrap: on
line source
/* XPM */ static char * gnome_add_xpm[] = { "24 24 29 1", " c None", ". c #000000", "+ c #706C60", "@ c #E0DCC0", "# c #6F6B5F", "$ c #6E6A5E", "% c #DEDABE", "& c #ADA798", "* c #686754", "= c #949480", "- c #BAB696", "; c #41413F", "> c #5F5F59", ", c #D4CCC0", "' c #A7A296", ") c #B3B090", "! c #484844", "~ c #84847C", "{ c #A19D90", "] c #4B4B48", "^ c #CEC7B9", "/ c #969289", "( c #BAB3A8", "_ c #6D6D66", ": c #AAA597", "< c #5B5B56", "[ c #7F7C71", "} c #5A5A54", "| c #8D897F", " ", " ", " ", " ... ", " ... ", " ... ", " ... ", " ... ", " ....... ", " ..... ", " ...+...@... ", " ..++#$#.@%%@@.. ", " .&.*+++=@@@-;>. ", " .,,'.*+=@)!>~~. ", " .,,,,{.+]>~~~~. ", " .,,,,,^.~~~~~~. ", " .,,,,,,.~~~~~~. ", " .,,,,,,.~~~~~~. ", " ./(,,,,.~~~~~_. ", " ..:,,,.~~~~<.. ", " .[(,.~~}.. ", " ..|.}.. ", " ... ", " "};