Mercurial > pidgin
view pixmaps/gnome_preferences.xpm @ 5531:10920646988f
[gaim-migrate @ 5931]
Ambrose LI (acli) writes:
" This is w.r.t. the 0.64cvs as of around 20:25 EDT.
When gaim starts up, it displays the signon window, and
then immeidately segfaults. The problem is that
tobase64() in util.c uses a size_t (which could very
likely be unsigned) as a second parameter, but proxy.c
calls it with a -1. "
at my questioning the specific change he made:
"Actually the initialization is not the matter (just
something I did while debugging and did not remove, since it
makes sense in any case), it's the other change that matters.
In util.h, the javadoc-like comments states that passing len
= -1 means that tobase64() should calculated len =
strlen(buf). However, since size_t is (or can be) unsigned,
the "if (len < 0)" check never succeeds, so passing
-1
actually results in a very large integer being passed.
So the "if (len < 0)" check actually need to be
changed so
that the passed "-1" will actually get recognized."
so since most of us aren't segfaulting on start, i'm guessing this is a
platform/os specific problem, but that the change shouldn't affect the
rest of us anyway.
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Mon, 26 May 2003 12:45:05 +0000 |
parents | 1a47432e2ba1 |
children |
line wrap: on
line source
/* XPM */ static char * gnome_preferences_xpm[] = { "22 24 53 1", " c None", ". c #000000", "+ c #E5E5E5", "@ c #CECECE", "# c #CDCDCD", "$ c #DCCB94", "% c #DCDCDC", "& c #C7C7C7", "* c #8E7D45", "= c #CFCFCF", "- c #C1C1C1", "; c #AB5959", "> c #D9D9D9", ", c #878787", "' c #DBDBDB", ") c #D4D4D4", "! c #A84F4F", "~ c #A7A7A7", "{ c #9B9B9B", "] c #F5F5F5", "^ c #F3F3F3", "/ c #A65757", "( c #6E6E6E", "_ c #DACACA", ": c #AC5757", "< c #C48B8B", "[ c #AA6C6C", "} c #E9DDDD", "| c #A65353", "1 c #C6C6C6", "2 c #D4C38D", "3 c #E4E4E4", "4 c #D6D6D0", "5 c #C0C0BB", "6 c #828279", "7 c #AD8E30", "8 c #756020", "9 c #C5C5BF", "0 c #A7A79A", "a c #818174", "b c #DFE1E1", "c c #D6E1E0", "d c #060605", "e c #A3A395", "f c #C8C8C8", "g c #8B8B7D", "h c #7E7E71", "i c #B2B9B6", "j c #D9D9D2", "k c #D9D9D3", "l c #DADAD4", "m c #DADAD9", "n c #DADADA", " ", " ", " ", " .. ", " ..+@. . ", " ..#+++. .$. ", " ...%+++++&. .$*. ", " ..#++++=+-++. .$*. ", " .%++++;+>+=,+'.$*. ", " .)++++!~+{,++.$*. ", " .++]^/+(+++.$*. ", " .%_:<[++++.$*.>. ", " .+}|/+++.$*.=+1. ", " .)+++++.2*.>3456. ", " .+++]78..90000a. ", " .%+bcd.ee0000f. ", " .+0ghijkl+m.. ", " .)+++++++f. ", " .++++++.. ", " .%+++f. ", " .+n.. ", " .. ", " ", " "};