Mercurial > pidgin
view pixmaps/join.xpm @ 5531:10920646988f
[gaim-migrate @ 5931]
Ambrose LI (acli) writes:
" This is w.r.t. the 0.64cvs as of around 20:25 EDT.
When gaim starts up, it displays the signon window, and
then immeidately segfaults. The problem is that
tobase64() in util.c uses a size_t (which could very
likely be unsigned) as a second parameter, but proxy.c
calls it with a -1. "
at my questioning the specific change he made:
"Actually the initialization is not the matter (just
something I did while debugging and did not remove, since it
makes sense in any case), it's the other change that matters.
In util.h, the javadoc-like comments states that passing len
= -1 means that tobase64() should calculated len =
strlen(buf). However, since size_t is (or can be) unsigned,
the "if (len < 0)" check never succeeds, so passing
-1
actually results in a very large integer being passed.
So the "if (len < 0)" check actually need to be
changed so
that the passed "-1" will actually get recognized."
so since most of us aren't segfaulting on start, i'm guessing this is a
platform/os specific problem, but that the change shouldn't affect the
rest of us anyway.
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Mon, 26 May 2003 12:45:05 +0000 |
parents | 725ffb93aedc |
children |
line wrap: on
line source
/* XPM */ static char * join_xpm[] = { "24 24 41 1", " c None", ". c #212121", "+ c #EAD4CB", "@ c #E3C5BA", "# c #DBB4A4", "$ c #EEDED7", "% c #FAF7F5", "& c #F2E5E1", "* c #D2AC99", "= c #000000", "- c #8D9E7C", "; c #CDD9C2", "> c #DEE6D7", ", c #DAE2D1", "' c #9BAD89", ") c #B79382", "! c #707D63", "~ c #B4C6A2", "{ c #ACC098", "] c #636E57", "^ c #AB8A7A", "/ c #E4E9DD", "( c #657158", "_ c #C49F8D", ": c #C3D1B5", "< c #808F70", "[ c #4C5442", "} c #58634E", "| c #E6EBE0", "1 c #D4DDC9", "2 c #CAD7BE", "3 c #90A17F", "4 c #5F6A53", "5 c #535C49", "6 c #E9EDE4", "7 c #616D56", "8 c #A8BC95", "9 c #7C8B6E", "0 c #4C5443", "a c #B6C2AA", "b c #5E6953", " ", " ", " ", " ", " ", " ", " ... ", " ..+@#.. ", " .$%&@*. ", " =======+#**. ", " =-;>,'=###). ", " =!~{]=##*^. ", " ==/;{(]=#*_. ", " ==/;:{<[}=)).. ", " =|12{{34=5=.. ", " =6{{{7= == ", " =>890= ", " =a]= ", " =b= ", " = ", " ", " ", " ", " "};