Mercurial > pidgin
view AUTHORS @ 8672:142108e89399
[gaim-migrate @ 9424]
"This patch contains two fixes. The first is rather trivial, just removes
the declaration of extra pointer used for deleting a message and
deletes the message directly.
The second is the real bug that needed fixing.
Short Explanation:
The old code only fixed the message that was being displayed, and
still sent the original unchecked message to the receiving party. All I
did was add a handler to the load_plugin function to make it fix the
message being sent as well.
Longer Explanation:
In my cursory look through the gaim code (warning, <15 minutes) it
appears the message pointer send to all the various *-im-msg and
*-chat-msg handlers is a copy of the original string each time. This
means if you fix the string at one stage (displaying), you have to fix it
again at the next (sending). This seems rather inefficient, but hey, it's
your client, maybe it was a design feature.
Anyway, the spellchk plugin was only fixing the displayed
message, and not the message being sent. So I thought my messages
were being fixed while those receiving them new I was screwing up. I
added substitute_somethingorother handler for the sending-im-msg
callback in the load_plugin function.
Other comments:
I didn't look to deeply into it since it's so late, but the
"displaying-chat-msg" and "sending-chat-msg" callbacks appear to
be broken. The spellchk.c currently has a handler registered for the
first callback, but the message displayed on my screen still contains
the original typos. If I try to register a handler for the second callback
listed, Gaim crashes when sending the message to a chat window. As
I said, I didn't look into why it was crashing, I just removed my
attempt to handle it and built this patch." --Matt Brenneke
committer: Tailor Script <tailor@pidgin.im>
| author | Luke Schierer <lschiere@pidgin.im> |
|---|---|
| date | Fri, 16 Apr 2004 14:39:34 +0000 |
| parents | 7da65537d28e |
| children | a6351c2b1150 |
line wrap: on
line source
gaim - the Pimpin' Penguin IM Clone that's Good for the Soul ============================================================ We've got an IRC room now too, #gaim on irc.freenode.net. Come check us out. Active Developers: ------------------ Rob Flynn <gaim@robflynn.com> - Maintainer AIM: RobFlynn ICQ: 1358450 MSN: rmf410@hotmail.com Yahoo: IBRRob Jabber: robflynn@jabber.org Sean Egan <bj91704@binghamton.edu> - Lead Developer AIM: SeanEgn ICQ: 96642211 MSN: SeanEgn@hotmail.com Yahoo: SeanEgn Jabber: SeanEgn@jabber.org Christian 'ChipX86' Hammond - Developer & Webmaster Herman 'Hermanator' Bloggs - Win32 Port Nathan 'faceprint' Walp - Developer Mark 'KingAnt' Doliner - Developer Luke 'LSchiere' Schierer - Support Crazy Patch Writers: -------------------- Ben Miller Decklin Foster Etan 'deryni' Reisner Ethan 'Paco-Paco' Blanton Robert 'Robot101' McQueen Retired: -------- Adam Fritzler - Former libfaim Maintainer Eric Warmenhoven <eric@warmenhoven.org> - Former Lead Developer Jim Duchek <jimduchek@ou.edu> - Former Maintainer Jim Seymour - Former Jabber Developer Mark Spencer <markster@marko.net> - Original Author Syd Logan - Hacker and Designated Driver (lazy bum)