Mercurial > pidgin
view acconfig.h @ 2347:182a4f8b1333
[gaim-migrate @ 2360]
Sorry rob. I just don't think that you should be committing what you know is half-complete code, and allow users to access it. We can't be recommending to people to be using CVS instead of releases and then add things that we know beforehand are buggy or incomplete. Also I don't think that you've implemented it properly: More than just Oscar have buddy icons (though Jabber is reworking their buddy icon stuff) and so it shouldn't be protocol-specific like this; also it should apply to the aim_user and not the gaim_connection, and you should be able to set it while you're not online, which means it should go in the Modify Account dialog and not the Protocol Actions dialog, with an OPT_PROTO_BUDDY_ICON flag so that the dialog knows whether or not the buddy icon can be set.
Also, you broke -Wall.
committer: Tailor Script <tailor@pidgin.im>
author | Eric Warmenhoven <eric@warmenhoven.org> |
---|---|
date | Sat, 22 Sep 2001 10:08:19 +0000 |
parents | 64d8ef561763 |
children | a7ecfd3f7714 |
line wrap: on
line source
#undef ENABLE_NLS #undef HAVE_CATGETS #undef HAVE_GETTEXT #undef HAVE_LC_MESSAGES #undef HAVE_STPCPY #undef HAVE_LIBSM #undef USE_APPLET #undef USE_GNOME #undef USE_PIXBUF #undef USE_SCREENSAVER #undef NO_MULTI #undef DEBUG #undef GAIM_PLUGINS #undef USE_PERL #undef NAS_SOUND #undef ESD_SOUND #undef ARTSC_SOUND #undef _REENTRANT #undef NEED_GNOMESUPPORT_H #undef NEED_SOCKLEN_T #undef ZEPHYR_INT32 #undef ZEPHYR_USES_KERBEROS #ifndef STATIC_PROTO_INIT #undef STATIC_PROTO_INIT #endif