Mercurial > pidgin
view COPYRIGHT @ 12229:18f0dadb29cf
[gaim-migrate @ 14531]
SF Patch #1366481 from Michael Carlson
"The function gtk_smiley_tree_insert() in gtkimhtml.c is
using up (on my system) the most CPU of all the
functions in gaim whenever the preferences box is
opened (tested by opening the preferences box 50 times
and measuring with oprofile).
The function is called some 297 times each time the
prefs box is opened, and each time we call strlen() on
a (usually 3 or 4) character string to see if the
string is empty or not.
I've eliminated the unnecessary call to strlen by
checking the first element, and I've changed the while
{} loop to a do {} while loop, because since we return
if the string is empty at the beginning of the
function, the same check on the first iteration of the
loop is unnecessary.
I believe it's faster for every case, even if only by a
little bit."
I don't know how necessary this is, but it doesn't hurt and it doesn't negatively impact the readability of the code.
I also fixed an existing piece of code for which the compiler issued a warning.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sat, 26 Nov 2005 17:09:29 +0000 |
parents | 56a3649c7bed |
children | 5bc3d67ceb24 |
line wrap: on
line source
Gaim Copyright (C) 1998-2005 by the following: If you have contributed to Gaim, you deserve to be on this list. Contact us (see: AUTHORS) and we'll add you. Dave Ahlswede Manuel Amador Matt Amato Daniel Atallah Paul Aurich Patrick Aussems John Bailey Luca Barbato Levi Bard Kevin Barry Derek Battams Martin Bayard Curtis Beattie Dave Bell Igor Belyi Brian Bernas Jonas Birmé Eric Blade Ethan Blanton Joshua Blanton Rainer Blessing Herman Bloggs David Blue Jason Boerner Graham Booker Craig Boston Chris Boyle Derrick J Brashear Matt Brenneke Jeremy Brooks Philip Brown Sean Burke Michael Carlson Julien Cegarra Cerulean Studios, LLC Jonathan Champ Ka-Hing Cheung Sadrul Habib Chowdhury Arturo Cisneros, Jr. Vincas Ciziunas Jonathan Clark Joe Clarke Eoin Coffey Jason Cohen Todd Cohen Nathan Conrad Felipe Contreras Alex Converse Irving Cordova Adam Cowell Palmer Cox Jeramey Crawford Balwinder Singh Dheeman Finlay Dobbie Mark Doliner Nuno Donato Jim Duchek Alex Duggan Tom Dyas Marc E. Andrew Echols John Eckerdal Sean Egan <sean.egan@binghamton.edu> Nelson Elhage Ignacio J. Elia Brian Enigma Stefan Esser Marc Etcheverry Larry Ewing Gábor Farkas Jesse Farmer Gavan Fantom (gavan) David Fiander Rob Flynn <gaim@robflynn.com> Rob Foehl (rwf) Alan Ford Nathan Fredrickson Chris J. Friesen Free Software Foundation Decklin Foster Francesco Fracassi Adam Fritzler Max G. François Gagné Evgueni V. Gavrilov Ignacy Gawedzki Richard Gobeille Michael Golden Charlie Gordon Ryan C. Gordon Miah Gregory Christian Hammond Erick Hamness Fred Hampton Casey Harkins Andy Harrison Andrew Hart (arhart) G. Sumner Hayes Michael R. Head Mike Heffner Benjamin Herrenschmidt Fernando Herrera Casey Ho Iain Holmes Joshua Honeycutt Nigel Horne Magnus Hult Karsten Huneycutt Rian Hunter Thomas Huriaux Henry Jen Benjamin Kahn Akuke Kok Cole Kowalski Gary Kramlich Patrik Kullman Tuomas Kuosmanen Tero Kuusela Richard Laager Scott Lamb Dennis Lambe Jr. Joe LaPenna Steve Láposi Daniel Larsson Peter Lawler Ho-seok Lee Moses Lei Ambrose C. Li Nicolas Lichtmaier Artem Litvinovich Syd Logan Lokheed Norberto Lopes Uli Luckas Matthew Luckie Mike Lundy Brian Macke Paolo Maggi Willian T. Mahan Kris Marsh Fidel Martinez Lalo Martins John Matthews Ryan McCabe Peter McCurdy Kurt McKee Torrey McMahon Robert McQueen Robert Mibus Benjamin Miller Kevin Miller Paul Miller Arkadiusz Miskiewicz Andrew Molloy Sergio Moretto Matthew A. Nicholson Szilard Novaki Novell Padraig O'Briain Christopher O'Brien (siege) Jon Oberheide Ruediger Oertel Gudmundur Bjarni Olafsson Nathan Owens (pianocomp81) Matt Pandina Ricardo Fernandez Pascual Riley Patterson Havoc Pennington Ted Percival Eduardo Pérez Joao Luís Marques Pinto Ari Pollak Robey Pointer Nathan Poznick Brent Priddy Federicco Mena Quintero Yosef Radchenko David Raeman Etan Reisner Kristian Rietveld Pekka Riikonen Tim Ringenbach Rhett Robinson Luciano Miguel Ferreira Rocha Andrew Rodland Jason Roth Jean-Francois Roy Arvind Samptur Sam S. Tom Samstag Neil Sanchala Alceste Scalas Carsten Schaar Luke Schierer Ralph Schmieder Evan Schoenberg Federico Schwindt Torrey Searle Peter Seebach Don Seiler Leonardo Serra Jim Seymour Joe Shaw Scott Shedden Ettore Simone John Silvestri Craig Slusher Alex Smith Malcolm Smith David Smock Phil Snowberger Eddie Sohn (tr1sk) Sony Computer Entertainment America, Inc. Mark Spencer Lex Spoon Kevin Stange Richard Stellingwerff David Stoddard Sun Microsystems Mårten Svantesson (fursten) Robert T. Brian Tarricone Peter Teichman Philip Tellis Arun A. Tharuvai Cestonaro Thilo Will Thompson Douglas Thrift (douglaswth) Andrew Tinney Jeffery To Warren Togami Stu Tomlinson Bill Tompkins Chris Toshok Ken Tossell Tom Tromey Todd Troxell Brad Turcotte Junichi Uekawa István Váradi Philip Van Hoof Kristof Vansant James Vega David Vermeille Sid Vicious Bjoern Voigt Nathan Walp Eric Warmenhoven Andrew Wellington Dave West Daniel Westermann-Clark Andrew Whewell Dan Willemsen Jason Willis Matt Wilson Justin Wood Ximian Jared Yanovich Timmy Yee Nickolai Zeldovich Marco Ziech Piotr Zielinski Jaroen Zwartepoorte