Mercurial > pidgin
view README.CVS @ 12229:18f0dadb29cf
[gaim-migrate @ 14531]
SF Patch #1366481 from Michael Carlson
"The function gtk_smiley_tree_insert() in gtkimhtml.c is
using up (on my system) the most CPU of all the
functions in gaim whenever the preferences box is
opened (tested by opening the preferences box 50 times
and measuring with oprofile).
The function is called some 297 times each time the
prefs box is opened, and each time we call strlen() on
a (usually 3 or 4) character string to see if the
string is empty or not.
I've eliminated the unnecessary call to strlen by
checking the first element, and I've changed the while
{} loop to a do {} while loop, because since we return
if the string is empty at the beginning of the
function, the same check on the first iteration of the
loop is unnecessary.
I believe it's faster for every case, even if only by a
little bit."
I don't know how necessary this is, but it doesn't hurt and it doesn't negatively impact the readability of the code.
I also fixed an existing piece of code for which the compiler issued a warning.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sat, 26 Nov 2005 17:09:29 +0000 |
parents | e4a27c9aec4c |
children |
line wrap: on
line source
If you plan to use gaim CVS, PLEASE read this message in its entirety! Gaim is a fast-moving project with a somewhat regular release schedule. Due to the rate of gaim development, CVS undergoes frequent bursts of massive changes, often leaving behind brokenness and partial functionality while the responsible developers rewrite some portion of code or seek to add new features. What this all boils down to is that CVS _WILL_ sometimes be broken. Because of this, we ask that users who are not interested in personally tracking down bugs and fixing them (without a lot of assistance from the developers!) avoid CVS and use releases. Since releases will be made often, this should not prevent anyone from using the newest, shiniest features -- but it will prevent users from having to deal with ugly development bugs that we already know about but haven't gotten around to fixing. If you are interested in hacking on gaim, please read README and HACKING, and take note of the issues in PROGRAMMING_NOTES. (Note that they may be somewhat out of date at times.) Win32 developers, please read README.mingw. By far the best documentation, however, is the documented code. Not all parts of gaim have yet been documented, but the major subsystems are falling fast. If you have doxygen, you can use the Doxyfile in the toplevel directory to generate pretty documentation. Otherwise (or even if you do!), the header files for each subsystem contain documentation for the functions they contain. For instance, conversation.h contains documentation for the entire gaim_conversation_* API, and account.h contains documentation for the gaim_account_* API. If you have questions, please feel free to contact the gaim developers by email at gaim-devel@lists.sourceforge.net, on IRC at irc.freenode.net in #gaim, or via the sourceforge forums at http://www.sourceforge.net/projects/gaim. Please do as much homework as you can before contacting us; the more you know about your question, the faster and more effectively we can help you! Send patches to gaim-devel@lists.sourceforge.net or post them in the Sourceforge forums at http://www.sourceforge.net/projects/gaim.