Mercurial > pidgin
view libpurple/plugins/tcl/Makefile.mingw @ 28855:1be982612d9a
*** Plucked rev 4be2df4f72bd8a55cdae7f2554b73342a497c92f (bcc0147bab874ca52c55ad4900545e17528bf8fd):
There's no need to check type twice here. Also, g_return_if_reached is not
correct since img==NULL is caused by invalid network input and not some
programmer error.
*** Plucked rev 3d02401cf232459fc80c0837d31e05fae7ae5467 (bcc0147bab874ca52c55ad4900545e17528bf8fd):
Using 'if (img==NULL) return;' fails to clean up properly, so invert the
logic of that section.
*** Plucked rev c64a1adc8bda2b4aeaae1f273541afbc4f71b810 (bcc0147bab874ca52c55ad4900545e17528bf8fd):
Each PurpleSmiley has a PurpleStoredImage behind it, so there's no need to
go and create a new one when someone asks for one.
Also, ignore requests for smileys that don't exist in the image store.
author | Daniel Atallah <daniel.atallah@gmail.com> |
---|---|
date | Thu, 07 Jan 2010 23:38:42 +0000 |
parents | ded8da3de5f8 |
children |
line wrap: on
line source
# # Makefile.mingw # # Description: Makefile for tcl plugin loader plugin. # PIDGIN_TREE_TOP := ../../.. include $(PIDGIN_TREE_TOP)/libpurple/win32/global.mak TARGET = tcl TCL_INC_DIR := $(TCL_LIB_TOP)/include DEFINES += -DHAVE_TK -DUSE_TCL_STUBS -DUSE_TK_STUBS ## ## INCLUDE PATHS ## INCLUDE_PATHS += -I. \ -I$(PIDGIN_TREE_TOP) \ -I$(PURPLE_TOP) \ -I$(PURPLE_TOP)/win32 \ -I$(GTK_TOP)/include \ -I$(GTK_TOP)/include/glib-2.0 \ -I$(GTK_TOP)/lib/glib-2.0/include \ -I$(TCL_INC_DIR) LIB_PATHS += -L$(GTK_TOP)/lib \ -L$(PURPLE_TOP) \ -L$(TCL_LIB_TOP) ## ## SOURCES, OBJECTS ## C_SRC = tcl.c \ tcl_cmd.c \ tcl_cmds.c \ tcl_glib.c \ tcl_ref.c \ tcl_signals.c OBJECTS = $(C_SRC:%.c=%.o) ## ## LIBRARIES ## LIBS = \ -lglib-2.0 \ -lws2_32 \ -lintl \ -lpurple \ -ltclstub84 \ -ltkstub84 include $(PIDGIN_COMMON_RULES) ## ## TARGET DEFINITIONS ## .PHONY: all install clean all: $(TARGET).dll install: all $(PURPLE_INSTALL_PLUGINS_DIR) cp $(TARGET).dll $(PURPLE_INSTALL_PLUGINS_DIR) $(OBJECTS): $(PURPLE_CONFIG_H) $(TARGET).dll: $(PURPLE_DLL).a $(OBJECTS) $(CC) -shared $(OBJECTS) $(LIB_PATHS) $(LIBS) $(DLL_LD_FLAGS) -o $(TARGET).dll ## ## CLEAN RULES ## clean: rm -rf $(OBJECTS) rm -rf $(TARGET).dll include $(PIDGIN_COMMON_TARGETS)