view PROGRAMMING_NOTES @ 12618:204bd8fac61f

[gaim-migrate @ 14954] SF Patch #1355796 from Sadrul This fixes the custom smiley bug where your text gets smilies from the other party in the conversation. This is a bit of a hack, but it fix things until such time as the smiley tree stuff can be reworked. " From the kwiki: If someone uses an MSN smiley, it shows up when I type the textual representation of it. For example, someone set a smiley (a rainbow flashy question mark) for ? and it showed up (on my side, I have no idea about theirs) for every ? I typed. /luke as I understand this report, the problem is that the custom smiley should be restricted to exactly one conversation but is in fact spanning the account/ * (sadrul) It appears what happens is, the custom smiley is added to the smiley-tree for that conversation-imhtml. So whenever any new message is going to be added to the imhtml, it looks up the smiley-tree first, and since the "?" (or anything else) matches the smiley, it converts it to the smiley. At first glance, it seems the fix would be non-trivial. It will probably be necessary to distinguish between custom-smileys (and also messages added to the imhtml) of the sender and the receiver. ==== end ==== What this patch does is, it temporarily replaces the smiley-tree for the conversation-imhtml with the smiley-tree of the conversation-entrybox. I think this will work because the smiley-trees of both these imhtml-s are initially the same. When a custom smiley is received, it is added the smiley-tree of the conversation-imhtml. So temporarily restoring the smiley-tree with the original smiley-tree (that in conv-entrybox) should fix the problem." committer: Tailor Script <[e-mail]>

+
��Notes on keeping GAIM OS independant
+
��------------------------------------
+
��
+
��General
+
��-------
+
��- Use G_DIR_SEPARATOR_S and G_DIR_SEPARATOR for paths
+
��
+
��- Use g_getenv, g_snprintf, g_vsnprintf
+
��
+
��- Use gaim_home_dir instead of g_get_home_dir or g_getenv("HOME")
+
��
+
��- Make sure when including win32dep.h that it is the last header to
+
��  be included.
+
��
+
��- Open binary files when reading or writing with 'b' mode.
+
��
+
��  e.g: fopen("somefile", "wb");
+
��
+
��  Not doing so will open files in windows using defaut translation mode. 
+
��  i.e. newline -> <CR><LF>
+
��
+
��Paths
+
��-----
+
��
+
��- DATADIR, LOCALEDIR & LIBDIR are defined in wingaim as functions.
+
��  Doing the following will therefore break the windows build:
+
��
+
��  printf("File in DATADIR is: %s\n", DATADIR G_DIR_SEPARATOR_S "pic.png");
+
��
+
��  it should be:
+
��
+
��  printf("File in DATADIR is: %s%s%s\n", DATADIR, G_DIR_SEPARATOR_S, "pic.png");
+
��
+
��PLUGINS & PROTOS
+
��----------------
+
��
+
��- G_MODULE_EXPORT all functions which are to be accessed from outside the
+
��  scope of its "dll" or "so". (E.G. gaim_plugin_init)
+
��
+
��- G_MODULE_IMPORT all global variables which are located outside your
+
��  dynamic library. (E.G. connections)
+
��
+
��  (Not doing this will cause "Memory Access Violations" in Win32)