Mercurial > pidgin
view pixmaps/status/default/op.svg @ 12618:204bd8fac61f
[gaim-migrate @ 14954]
SF Patch #1355796 from Sadrul
This fixes the custom smiley bug where your text gets smilies from the other party in the conversation.
This is a bit of a hack, but it fix things until such time as the smiley tree stuff can be reworked.
" From the kwiki:
If someone uses an MSN smiley, it shows up when I type
the textual representation of it. For example, someone
set a smiley (a rainbow flashy question mark) for ? and
it showed up (on my side, I have no idea about theirs)
for every ? I typed. /luke as I understand this report,
the problem is that the custom smiley should be
restricted to exactly one conversation but is in fact
spanning the account/
* (sadrul) It appears what happens is, the custom
smiley is added to the smiley-tree for that
conversation-imhtml. So whenever any new message is
going to be added to the imhtml, it looks up the
smiley-tree first, and since the "?" (or anything else)
matches the smiley, it converts it to the smiley. At
first glance, it seems the fix would be non-trivial. It
will probably be necessary to distinguish between
custom-smileys (and also messages added to the imhtml)
of the sender and the receiver.
==== end ====
What this patch does is, it temporarily replaces the
smiley-tree for the conversation-imhtml with the
smiley-tree of the conversation-entrybox. I think this
will work because the smiley-trees of both these
imhtml-s are initially the same. When a custom smiley
is received, it is added the smiley-tree of the
conversation-imhtml. So temporarily restoring the
smiley-tree with the original smiley-tree (that in
conv-entrybox) should fix the problem."
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Thu, 22 Dec 2005 04:07:21 +0000 |
parents | 8b2451878e26 |
children |
line wrap: on
line source
<?xml version="1.0" encoding="UTF-8" standalone="no"?> <!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.0//EN" "http://www.w3.org/TR/2001/REC-SVG-20010904/DTD/svg10.dtd"> <!-- Created with Sodipodi ("http://www.sodipodi.com/") --> <svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" version="1.0" x="0" y="0" width="40" height="40" id="svg644" xml:space="preserve"><defs id="defs646"><linearGradient id="linearGradient651"><stop style="stop-color:#000000;stop-opacity:1;" offset="0" id="stop652" /><stop style="stop-color:#ffffff;stop-opacity:1;" offset="1" id="stop653" /></linearGradient><radialGradient cx="0.5" cy="0.5" r="0.5" fx="0.5" fy="0.5" id="radialGradient654" xlink:href="#linearGradient651" /><linearGradient x1="-6.36533315e-9" y1="-1.07861e-8" x2="1.00000012" y2="-1.07861e-8" id="linearGradient655" xlink:href="#linearGradient651" gradientUnits="objectBoundingBox" spreadMethod="pad" /></defs><polygon points="31.88484,36.4384 20.28064,30.48507 8.797826,36.6693 10.87388,23.79337 1.443943,14.7836 14.33122,12.77916 19.98601,1.026588 25.87473,12.66371 38.79951,14.40999 29.55167,23.60656 31.88484,36.4384 " transform="translate(2.384186e-6,1.696012)" style="font-size:12;fill:#01ff00;stroke:#000000;stroke-width:2.5;stroke-linecap:round;stroke-linejoin:round;" id="polygon650" /></svg>