Mercurial > pidgin
view libpurple/purple.h.in @ 31203:258fec7797b9
Attempt to fix a crash I've seen a few times. I think it happens if you
have a conversation window open with a MySpace buddy, then your MySpace
account goes offline. We apparently call the prpl's status_text prpl
function to get the status text for the buddy, but the connection is
offline. I don't know if that's something we SHOULD do or not... but
other prpl's seem to handle this, at least.
1. Use buddy->account instead of buddy->account->gc->proto_data->account,
since the former should always exist and later doesn't exist if the
account is offline. This was leading to a null pointer dereference.
2. Pass FALSE to msim_get_user_from_buddy() so that it will stop creating
an MsimUser struct if one doesn't exist. Creating it didn't accomplish
anything, and I feel like it might never get freed if the account is
already offline.
3. Put the checks for user->headline and user->display_name in a big
if condition, so we won't try to grab that info if user is NULL
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Mon, 14 Feb 2011 01:01:37 +0000 |
parents | 6183fc8c0533 |
children | 02a2e8183b1d |
line wrap: on
line source
/** * @file purple.h Header files and defines * This file contains all the necessary preprocessor directives to include * libpurple's headers and other preprocessor directives required for plugins * or UIs to build. Including this file eliminates the need to directly * include any other libpurple files. * * @ingroup core libpurple * @since 2.3.0 */ /* purple * * Purple is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef _PURPLE_PURPLE_H_ #define _PURPLE_PURPLE_H_ #include <glib.h> #ifndef G_GNUC_NULL_TERMINATED # if __GNUC__ >= 4 # define G_GNUC_NULL_TERMINATED __attribute__((__sentinel__)) # else # define G_GNUC_NULL_TERMINATED # endif #endif @PLUGINS_DEFINE@ #include <account.h> #include <accountopt.h> #include <blist.h> #include <buddyicon.h> #include <certificate.h> #include <cipher.h> #include <circbuffer.h> #include <cmds.h> #include <connection.h> #include <conversation.h> #include <core.h> #include <debug.h> #include <desktopitem.h> #include <dnsquery.h> #include <dnssrv.h> #include <eventloop.h> #include <ft.h> #include <idle.h> #include <imgstore.h> #include <log.h> #include <media.h> #include <mediamanager.h> #include <mime.h> #include <nat-pmp.h> #include <network.h> #include <notify.h> #include <ntlm.h> #include <plugin.h> #include <pluginpref.h> #include <pounce.h> #include <prefs.h> #include <privacy.h> #include <proxy.h> #include <prpl.h> #include <request.h> #include <roomlist.h> #include <savedstatuses.h> #include <server.h> #include <signals.h> #include <smiley.h> #include <sound.h> #include <sound-theme.h> #include <sound-theme-loader.h> #include <sslconn.h> #include <status.h> #include <stringref.h> #include <stun.h> #include <theme.h> #include <theme-loader.h> #include <theme-manager.h> #include <upnp.h> #include <util.h> #include <value.h> #include <version.h> #include <whiteboard.h> #include <xmlnode.h> #endif