Mercurial > pidgin
view AUTHORS @ 4029:31480901bf29
[gaim-migrate @ 4233]
"with the change to .60 and the new method of using perl_call
argument parsing was broken. What essentially happened is that the
previous method of pre-parsing was to generate a string in the for
'arg one','arg two','arg three' and execute the perl function via
&perlfunc(args). This would make the perl function in essense parse
the variables for us. With the introduction of perl_call, however, that
argument list was being treated as one long, singular argument.
perl_call asks for lists of pointers to character arrays that are NULL
terminated, and it passes them into the function using an internal
method.
With this said, I changed the function execute_perl from requiring
(char* function, char* args) to (char* function, char** args). It no
longer takes a single argument and inserts it into the appropriate data
type that is terminated with a NULL element, instead you now have
to pass it a pre-NULL terminated array of character pointers to
accomodate some functions wanting to give it more than one
argument. I modified the functions that use execute_perl to use this
method, and commented those lines, as well chopping the multiple
argument section into buf[0] = looking sections for clarity. Finally, I
inserted a heft comment above execute_perl to try and explain what I
did, I hope it is understandable. "
-- Eric Timme (var1ety)
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Sun, 01 Dec 2002 20:43:00 +0000 |
parents | b9dd12ebea83 |
children | 16f7f9451814 |
line wrap: on
line source
gaim - the Pimpin' Penguin IM Clone that's Good for the Soul ============================================================ Developers: ---------- Rob Flynn <rob@marko.net> - Main developer (send patches here) AIM: RobFlynn ICQ: 1358450 MSN: rmf410@hotmail.com Yahoo: IBRRob Jabber: robflynn@jabber.org Sean Egan <bj91704@binghamton.edu> - Developer AIM: SeanEgn ICQ: 96642211 MSN: SeanEgn@hotmail.com Yahoo: SeanEgn Jabber: SeanEgn@jabber.org Syd Logan - Hacker and Designated Driver (lazy bum) Decklin Foster Ben Miller Nathan Walp Mark Doliner We've got an IRC room now too, #gaim on irc.openprojects.net. Come check us out. Retired: -------- Jim Duchek <jimduchek@ou.edu> - Former Maintainer Mark Spencer <markster@marko.net> - Original Author Eric Warmenhoven <eric@warmenhoven.org> Adam Fritzler