Mercurial > pidgin
view libpurple/plugins/simple.c @ 16620:36981d83b20c
Fix a crash when removing a per-account icon. Here's my explanation:
21:45:22 rlaager: Since we're not saving the buddy icon path to disk (which, as I mentioned earlier, only exists because of QQ), we end up with that being NULL, which is fine.
21:46:08 rlaager: Where fine = fine, as long as we don't care about QQ and if we do, my changes didn't change that behavior, so it's no worse. ;)
21:46:33 rlaager: The crash in the buddy icon code happens because filename is NULL. In that case, we can return, because the image_deleting_cb is only concerned with those PurpleStoredImages that were created by the buddy icon code. I'll commit the fix.
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sun, 29 Apr 2007 02:49:23 +0000 |
parents | 32c366eeeb99 |
children | d638845509fd |
line wrap: on
line source
#include "internal.h" #include "debug.h" #include "plugin.h" #include "version.h" /** Plugin id : type-author-name (to guarantee uniqueness) */ #define SIMPLE_PLUGIN_ID "core-ewarmenhoven-simple" static gboolean plugin_load(PurplePlugin *plugin) { purple_debug(PURPLE_DEBUG_INFO, "simple", "simple plugin loaded.\n"); return TRUE; } static gboolean plugin_unload(PurplePlugin *plugin) { purple_debug(PURPLE_DEBUG_INFO, "simple", "simple plugin unloaded.\n"); return TRUE; } static PurplePluginInfo info = { PURPLE_PLUGIN_MAGIC, PURPLE_MAJOR_VERSION, PURPLE_MINOR_VERSION, PURPLE_PLUGIN_STANDARD, /**< type */ NULL, /**< ui_requirement */ 0, /**< flags */ NULL, /**< dependencies */ PURPLE_PRIORITY_DEFAULT, /**< priority */ SIMPLE_PLUGIN_ID, /**< id */ N_("Simple Plugin"), /**< name */ VERSION, /**< version */ /** summary */ N_("Tests to see that most things are working."), /** description */ N_("Tests to see that most things are working."), "Eric Warmenhoven <eric@warmenhoven.org>", /**< author */ PURPLE_WEBSITE, /**< homepage */ plugin_load, /**< load */ plugin_unload, /**< unload */ NULL, /**< destroy */ NULL, /**< ui_info */ NULL, /**< extra_info */ NULL, NULL }; static void init_plugin(PurplePlugin *plugin) { } PURPLE_INIT_PLUGIN(simple, init_plugin, info)