view README.MTN @ 24476:3d6fe79753c3

This should fix another crash I've seen. We weren't correctly cancelling the proxy connect when we destroyed the servconn because we were only calling msn_servconn_disconnect() if we had actually connected. So always call msn_servconn_disconnect() from msn_servconn_destroy() and let the disconnect function deal with only closing stuff that is actually open. Here's the backtrace: #0 0x0000000000000000 in ?? () #1 0x00000000005f95e0 in connect_cb (data=0x2ab92ef6e7b0, source=7, error_message=0x0) at servconn.c:185 #2 0x000000000056e7da in purple_proxy_connect_data_connected (connect_data=0x2ab92ef70260) at proxy.c:598 #3 0x000000000056e90d in socket_ready_cb (data=0x2ab92ef70260, source=7, cond=PURPLE_INPUT_WRITE) at proxy.c:657 #4 0x00000000004db70c in pidgin_io_invoke (source=0x2ab92ee4be50, condition=G_IO_OUT, data=0x2ab92dfd3130) at gtkeventloop.cc:79 In frame 1, servconn is not valid (it has already been freed)
author Mark Doliner <mark@kingant.net>
date Tue, 18 Nov 2008 07:32:23 +0000
parents e0bcb8cfda74
children
line wrap: on
line source

If you plan to use Pidgin, Finch and libpurple from our Monotone repository,
PLEASE read this message in its entirety!

Pidgin, Finch, and libpurple are a fast-moving project with a somewhat regular
release schedule.  Due to the rate of development, the code in our Monotone
repository undergoes frequent bursts of massive changes, often leaving behind
brokenness and partial functionality while the responsible developers rewrite
some portion of code or seek to add new features.

What this all boils down to is that the code in our Monotone repository _WILL_
sometimes be broken.  Because of this, we ask that users who are not interested
in personally tracking down bugs and fixing them (without a lot of
assistance from the developers!) use only released versions.  Since releases
will be made often, this should not prevent anyone from using the newest,
shiniest features -- but it will prevent users from having to deal with ugly
development bugs that we already know about but haven't gotten around to fixing.

If you are interested in hacking on Pidgin, Finch, and/or libpurple, please
check out the information available at: http://developer.pidgin.im

By far the best documentation, however, is the documented code.  If you have
doxygen, you can run "make docs" in the toplevel directory to generate pretty
documentation.  Otherwise (or even if you do!), the header files for each
subsystem contain documentation for the functions they contain.  For instance,
conversation.h contains documentation for the entire purple_conversation_*
API, and account.h contains documentation for the purple_account_* API.

If you have questions, please feel free to contact the Pidgin, Finch, and
libpurple developers by email at devel@pidgin.im or on IRC at irc.freenode.net
in #pidgin.  Please do as much homework as you can before contacting us; the
more you know about your question, the faster and more effectively we can help!

Patches should be posted as Trac tickets at: http://developer.pidgin.im