Mercurial > pidgin
view finch/libgnt/gntstyle.h @ 31228:43f661bc82ed
Fixes this crash:
1. Open an IM window with someone who has just gone online or offline
2. Delete your account from the Accounts window
3. Wait for the 11 second timer to trigger
The conversation code was setting an 11 second timer when a buddy signs
online or offline so that it could stop showing the open door or close
door icon for the buddy, similar to what we do in the buddy list. However,
we didn't keep track of the handle for this timer and didn't clear it if
the account is deleted--thus the crash.
I noticed that we don't currently show the open door or close door icons
in the conversation window. I think it would be good if we did... but
I don't think the gtkconv code should keep track of this information.
gtkblist.c already keeps track of it in gtknode->recent_signonoff_timer.
We should either re-use that, or better yet, we should add "recent signon"
and "recent signoff" states to the status system somehow.
But I don't feel like working on that... it's pretty minor. In any case
I don't think this code is the right way to handle it, so I'm getting
rid of it. Feel free to disapprove this if you disagree! (But also please
fix the crash, maybe just by disabling the timer for now)
I'm also getting rid of the login_list and logout_list lists, since they're
not used.
1 file changed, 33 deletions(-)
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Fri, 18 Feb 2011 07:51:43 +0000 |
parents | 39b078ac8a81 |
children |
line wrap: on
line source
/** * @file gntstyle.h Style API * @ingroup gnt */ /* * GNT - The GLib Ncurses Toolkit * * GNT is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This library is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #include "gnt.h" #include "gntwm.h" typedef enum { GNT_STYLE_SHADOW = 0, GNT_STYLE_COLOR = 1, GNT_STYLE_MOUSE = 2, GNT_STYLE_WM = 3, GNT_STYLE_REMPOS = 4, GNT_STYLES } GntStyle; /** * Read configuration from a file. * * @param filename The filename to read configuration from. */ void gnt_style_read_configure_file(const char *filename); /** * Get the user-setting for a style. * @param style The style. * @return The user-setting, or @c NULL. */ const char *gnt_style_get(GntStyle style); /** * Get the value of a preference in ~/.gntrc. * * @param group The name of the group in the keyfile. If @c NULL, the prgname * will be used first, if available. Otherwise, "general" will be used. * @param key The key * * @return The value of the setting as a string, or @c NULL * * @since 2.0.0 (gnt), 2.1.0 (pidgin) */ char *gnt_style_get_from_name(const char *group, const char *key); /** * Get the value of a preference in ~/.gntrc. * * @param group The name of the group in the keyfile. If @c NULL, the prgname * will be used first, if available. Otherwise, "general" will be used. * @param key The key * @param length Return location for the number of strings returned, or NULL * * @return NULL terminated string array. The array should be freed with g_strfreev(). * * @since 2.4.0 */ char **gnt_style_get_string_list(const char *group, const char *key, gsize *length); /** * Get the value of a color pair in ~/.gntrc. * * @param group The name of the group in the keyfile. If @c NULL, the prgname * will be used first, if available. Otherwise, "general" will be used. * @param key The key * * @return The value of the color as an int, or 0 on error. * * @since 2.4.0 */ int gnt_style_get_color(char *group, char *key); /** * Parse a boolean preference. For example, if 'value' is "false" (ignoring case) * or "0", the return value will be @c FALSE, otherwise @c TRUE. * * @param value The value of the boolean setting as a string * @return The boolean value * * @since 2.0.0 (gnt), 2.1.0 (pidgin) */ gboolean gnt_style_parse_bool(const char *value); /** * Get the boolean value for a user-setting. * * @param style The style. * @param def The default value (i.e, the value if the user didn't define * any value) * * @return The value of the setting. */ gboolean gnt_style_get_bool(GntStyle style, gboolean def); /** * @internal */ void gnt_styles_get_keyremaps(GType type, GHashTable *hash); /** * @internal */ void gnt_style_read_actions(GType type, GntBindableClass *klass); /** * Read menu-accels from ~/.gntrc * * @param name The name of the window. * @param table The hastable to store the accel information. * * @return @c TRUE if some accels were read, @c FALSE otherwise. */ gboolean gnt_style_read_menu_accels(const char *name, GHashTable *table); /** * @internal * Read workspace information. */ void gnt_style_read_workspaces(GntWM *wm); /** * Initialize style settings. */ void gnt_init_styles(void); /** * Uninitialize style settings. */ void gnt_uninit_styles(void);