Mercurial > pidgin
view libpurple/dbus-define-api.h @ 31228:43f661bc82ed
Fixes this crash:
1. Open an IM window with someone who has just gone online or offline
2. Delete your account from the Accounts window
3. Wait for the 11 second timer to trigger
The conversation code was setting an 11 second timer when a buddy signs
online or offline so that it could stop showing the open door or close
door icon for the buddy, similar to what we do in the buddy list. However,
we didn't keep track of the handle for this timer and didn't clear it if
the account is deleted--thus the crash.
I noticed that we don't currently show the open door or close door icons
in the conversation window. I think it would be good if we did... but
I don't think the gtkconv code should keep track of this information.
gtkblist.c already keeps track of it in gtknode->recent_signonoff_timer.
We should either re-use that, or better yet, we should add "recent signon"
and "recent signoff" states to the status system somehow.
But I don't feel like working on that... it's pretty minor. In any case
I don't think this code is the right way to handle it, so I'm getting
rid of it. Feel free to disapprove this if you disagree! (But also please
fix the crash, maybe just by disabling the timer for now)
I'm also getting rid of the login_list and logout_list lists, since they're
not used.
1 file changed, 33 deletions(-)
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Fri, 18 Feb 2011 07:51:43 +0000 |
parents | 32c366eeeb99 |
children |
line wrap: on
line source
#error "This is file is not a valid C code" /* This file contains some of the macros from other header files as function declarations. This does not make sense in C, but it provides type information for the dbus-analyze-functions.py program, which makes these macros callable by DBUS. */ /* blist.h */ gboolean PURPLE_BLIST_NODE_IS_CHAT(PurpleBlistNode *node); gboolean PURPLE_BLIST_NODE_IS_BUDDY(PurpleBlistNode *node); gboolean PURPLE_BLIST_NODE_IS_CONTACT(PurpleBlistNode *node); gboolean PURPLE_BLIST_NODE_IS_GROUP(PurpleBlistNode *node); gboolean PURPLE_BUDDY_IS_ONLINE(PurpleBuddy *buddy); gboolean PURPLE_BLIST_NODE_HAS_FLAG(PurpleBlistNode *node, int flags); gboolean PURPLE_BLIST_NODE_SHOULD_SAVE(PurpleBlistNode *node); /* connection.h */ gboolean PURPLE_CONNECTION_IS_CONNECTED(PurpleConnection *connection); gboolean PURPLE_CONNECTION_IS_VALID(PurpleConnection *connection); /* conversation.h */ PurpleConvIm *PURPLE_CONV_IM(const PurpleConversation *conversation); PurpleConvIm *PURPLE_CONV_CHAT(const PurpleConversation *conversation);