Mercurial > pidgin
view valgrind-suppressions @ 31228:43f661bc82ed
Fixes this crash:
1. Open an IM window with someone who has just gone online or offline
2. Delete your account from the Accounts window
3. Wait for the 11 second timer to trigger
The conversation code was setting an 11 second timer when a buddy signs
online or offline so that it could stop showing the open door or close
door icon for the buddy, similar to what we do in the buddy list. However,
we didn't keep track of the handle for this timer and didn't clear it if
the account is deleted--thus the crash.
I noticed that we don't currently show the open door or close door icons
in the conversation window. I think it would be good if we did... but
I don't think the gtkconv code should keep track of this information.
gtkblist.c already keeps track of it in gtknode->recent_signonoff_timer.
We should either re-use that, or better yet, we should add "recent signon"
and "recent signoff" states to the status system somehow.
But I don't feel like working on that... it's pretty minor. In any case
I don't think this code is the right way to handle it, so I'm getting
rid of it. Feel free to disapprove this if you disagree! (But also please
fix the crash, maybe just by disabling the timer for now)
I'm also getting rid of the login_list and logout_list lists, since they're
not used.
1 file changed, 33 deletions(-)
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Fri, 18 Feb 2011 07:51:43 +0000 |
parents | a8d6f071eb6d |
children |
line wrap: on
line source
{ X oddness 1 Memcheck:Param write(buf) fun:__write_nocancel fun:_X11TransWrite obj:/usr/X11R6/lib/libX11.so.6.2 fun:_XReply } { NSS Memcheck:Cond obj:/usr/lib/libsoftokn3.so obj:/usr/lib/libsoftokn3.so obj:/usr/lib/libsoftokn3.so obj:/usr/lib/libsoftokn3.so } { X oddness 2 Memcheck:Param writev(vector[...]) fun:writev obj:/usr/X11R6/lib/libX11.so.6.2 fun:_X11TransWritev fun:_XSend } { X oddness 3 Memcheck:Cond fun:XcursorImageHash fun:XcursorNoticePutBitmap fun:_XNoticePutBitmap fun:XPutImage } { X oddness 4 Memcheck:Param write(buf) fun:__write_nocancel fun:_X11TransWrite obj:/usr/X11R6/lib/libX11.so.6.2 fun:XFlush } { X oddness 5 Memcheck:Param write(buf) fun:__write_nocancel fun:_X11TransWrite obj:/usr/X11R6/lib/libX11.so.6.2 fun:XDrawLine } { X oddness 6 Memcheck:Param write(buf) fun:__write_nocancel fun:_X11TransWrite obj:/usr/X11R6/lib/libX11.so.6.2 fun:_XEventsQueued } { File selector Memcheck:Value4 fun:_itoa_word fun:_IO_vfprintf_internal fun:_IO_vsprintf_internal fun:_IO_sprintf } { File selector 2 Memcheck:Param write(buf) fun:__write_nocancel fun:_X11TransWrite obj:/usr/X11R6/lib/libX11.so.6.2 fun:XRenderComposite } { TCL leak Memcheck:Leak fun:malloc fun:TclpAlloc fun:Tcl_Alloc fun:Tcl_StaticPackage } { FontConfig Maybe Memcheck:Leak fun:malloc fun:FcStrCopy fun:FcStrSetAdd fun:FcLangSetCopy } { File selector 3 Memcheck:Param write(buf) fun:__write_nocancel fun:_X11TransWrite obj:/usr/X11R6/lib/libX11.so.6.2 fun:_XFlushGCCache } { File selector 4 Memcheck:Param write(buf) fun:__write_nocancel fun:_X11TransWrite obj:/usr/X11R6/lib/libX11.so.6.2 fun:XCreateGC } { Something else Memcheck:Param write(buf) fun:__write_nocancel fun:_X11TransWrite obj:/usr/X11R6/lib/libX11.so.6.2 fun:_XSetClipRectangles } { New conversation windows Memcheck:Cond obj:/usr/lib/libgtk-x11-2.0.so.0.400.14 obj:/usr/lib/libgtk-x11-2.0.so.0.400.14 obj:/usr/lib/libgtk-x11-2.0.so.0.400.14 obj:/usr/lib/libgtk-x11-2.0.so.0.400.14 } { New conversation windows 2 Memcheck:Cond obj:/usr/lib/libgtk-x11-2.0.so.0.400.14 obj:/usr/lib/libgtk-x11-2.0.so.0.400.14 obj:/usr/lib/libgtk-x11-2.0.so.0.400.14 obj:/usr/lib/libgobject-2.0.so.0.400.8 } { NSS Init Memcheck:Leak fun:malloc fun:PR_Malloc fun:PR_CreateStack fun:_PR_InitFdCache fun:_PR_InitIO fun:_PR_ImplicitInitialization fun:PR_Init fun:rsa_nss_init fun:GE_plugin_load fun:purple_plugin_load fun:purple_plugins_load_saved fun:main }