Mercurial > pidgin
view src/protocols/msn/command.h @ 13905:4e44ecb866bd
[gaim-migrate @ 16394]
msn_session_sync_users() iterates over the buddy list, following the ->next pointers of the groups, contacts, and buddies. msn_show_sync_issue(), if called, removed the buddy for which it was called, in preparation for the buddy either being added to the server list or confirmed-to-be-removed. This could lead to the buddy pointer being released and ->next therefore being junk.
The buddy is now not removed until the user responds to the action dialog presented via msn_show_sync_issue(). I'm unclear why gtkgaim got away with this exercise in memory stomping but Adium/libgaim crashed every time, but it's safer in any case.
I also changed some foo->bar to gaim_foo_get_bar().
committer: Tailor Script <tailor@pidgin.im>
author | Evan Schoenberg <evan.s@dreskin.net> |
---|---|
date | Sun, 02 Jul 2006 09:37:25 +0000 |
parents | b3d334f60732 |
children |
line wrap: on
line source
/** * @file command.h MSN command functions * * gaim * * Gaim is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef _MSN_COMMAND_H #define _MSN_COMMAND_H typedef struct _MsnCommand MsnCommand; #include "cmdproc.h" #include "transaction.h" typedef void (*MsnPayloadCb)(MsnCmdProc *cmdproc, MsnCommand *cmd, char *payload, size_t len); /** * A received command. */ struct _MsnCommand { unsigned int trId; char *command; char **params; int param_count; int ref_count; MsnTransaction *trans; char *payload; size_t payload_len; MsnPayloadCb payload_cb; }; MsnCommand *msn_command_from_string(const char *string); void msn_command_destroy(MsnCommand *cmd); MsnCommand *msn_command_ref(MsnCommand *cmd); MsnCommand *msn_command_unref(MsnCommand *cmd); #endif /* _MSN_COMMAND_H */