Mercurial > pidgin
view libpurple/protocols/oscar/visibility.c @ 30376:50d472b3d752
Fixed a bug I accidentally introduced in fb1ab831dedebf45ea50b6f87bfc00265a0115ef.
We now have two different set_perm_deny()'s with different semantics
(the ICQ one controls visibility, the AIM one, blocking), but
purple_ssi_parselist() always called the ICQ one, no matter what
is the current account.
I've also changed the names of functions to make the distinction clearer.
author | ivan.komarov@soc.pidgin.im |
---|---|
date | Thu, 01 Jul 2010 18:56:17 +0000 |
parents | ab7e28b1b478 |
children | c5790044f32f |
line wrap: on
line source
/* * Purple's oscar protocol plugin * This file is the legal property of its developers. * Please see the AUTHORS file distributed alongside this file. * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * version 2 of the License, or (at your option) any later version. * * This library is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU * Lesser General Public License for more details. * * You should have received a copy of the GNU Lesser General Public * License along with this library; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #include "visibility.h" /* 4 separate strings are needed in order to ease translators' job */ #define APPEAR_ONLINE N_("Appear Online") #define DONT_APPEAR_ONLINE N_("Don't Appear Online") #define APPEAR_OFFLINE N_("Appear Offline") #define DONT_APPEAR_OFFLINE N_("Don't Appear Offline") static guint16 get_buddy_list_type(OscarData *od, const char *bname) { PurpleAccount *account = purple_connection_get_account(od->gc); return purple_account_is_status_active(account, OSCAR_STATUS_ID_INVISIBLE) ? AIM_SSI_TYPE_PERMIT : AIM_SSI_TYPE_DENY; } static gboolean is_buddy_on_list(OscarData *od, const char *bname) { return aim_ssi_itemlist_finditem(od->ssi.local, NULL, bname, get_buddy_list_type(od, bname)) != NULL; } static void visibility_cb(PurpleBlistNode *node, gpointer whatever) { PurpleBuddy *buddy = PURPLE_BUDDY(node); const char* bname = purple_buddy_get_name(buddy); OscarData *od = purple_connection_get_protocol_data(purple_account_get_connection(purple_buddy_get_account(buddy))); guint16 list_type = get_buddy_list_type(od, bname); if (!is_buddy_on_list(od, bname)) { aim_ssi_add_to_private_list(od, bname, list_type); } else { aim_ssi_del_from_private_list(od, bname, list_type); } } PurpleMenuAction * create_visibility_menu_item(OscarData *od, const char *bname) { PurpleAccount *account = purple_connection_get_account(od->gc); gboolean invisible = purple_account_is_status_active(account, OSCAR_STATUS_ID_INVISIBLE); gboolean on_list = is_buddy_on_list(od, bname); const gchar *label; if (invisible) { label = on_list ? _(DONT_APPEAR_ONLINE) : _(APPEAR_ONLINE); } else { label = on_list ? _(DONT_APPEAR_OFFLINE) : _(APPEAR_OFFLINE); } return purple_menu_action_new(label, PURPLE_CALLBACK(visibility_cb), NULL, NULL); } static void show_private_list(PurplePluginAction *action, guint16 list_type, const gchar *list_description, const gchar *menu_action_name) { PurpleConnection *gc = (PurpleConnection *) action->context; OscarData *od = purple_connection_get_protocol_data(gc); PurpleAccount *account = purple_connection_get_account(gc); GSList *buddies, *filtered_buddies, *cur; gchar *text, *secondary; buddies = purple_find_buddies(account, NULL); filtered_buddies = NULL; for (cur = buddies; cur != NULL; cur = cur->next) { PurpleBuddy *buddy; const gchar *bname; buddy = cur->data; bname = purple_buddy_get_name(buddy); if (aim_ssi_itemlist_finditem(od->ssi.local, NULL, bname, list_type)) { filtered_buddies = g_slist_prepend(filtered_buddies, buddy); } } g_slist_free(buddies); filtered_buddies = g_slist_reverse(filtered_buddies); text = oscar_format_buddies(filtered_buddies, _("you have no buddies on this list")); g_slist_free(filtered_buddies); secondary = g_strdup_printf(_("You can add a buddy to this list " "by right-clicking on them and " "selecting \"%s\""), menu_action_name); purple_notify_formatted(gc, NULL, list_description, secondary, text, NULL, NULL); g_free(secondary); g_free(text); } void oscar_show_visible_list(PurplePluginAction *action) { show_private_list(action, AIM_SSI_TYPE_PERMIT, _("These buddies will see " "your status when you switch " "to \"Invisible\""), _(APPEAR_ONLINE)); } void oscar_show_invisible_list(PurplePluginAction *action) { show_private_list(action, AIM_SSI_TYPE_DENY, _("These buddies will always see you as offline"), _(APPEAR_OFFLINE)); }