Mercurial > pidgin
view libpurple/protocols/jabber/ping.c @ 24121:5395b18f9f08
Revert my revision 849d4f7265598a9f0340411c4c0c0401d488ec3b, which
removed the select() code in child DNS processes. Stu pointed out
that this code is what allowed our child DNS processes to hang
around for 40 seconds waiting for additional requests, then die a
natural death.
But that wasn't happening even WITH the select code because the parent
was killing the DNS children when it was done with them. So I
made another change to set the resolver to NULL so that it isn't
killed by purple_dnsquery_destroy().
I'm assuming that we still want our DNS lookup children to hang around
for a little while after they're done. I reduced the timeout from 40
seconds to 20 seconds.
An arguably better way to do this is to go back to having the child
block on read() instead of calling select(), then have the parent
set a timer that kills the child after a certain about of time. But
I don't see an advantage to doing it either way, and this is simpler.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Tue, 16 Sep 2008 17:56:01 +0000 |
parents | 413103ddeaac |
children | e30e9779e7bf b5052c66701c |
line wrap: on
line source
/* * purple - Jabber Protocol Plugin * * Copyright (C) 2003, Nathan Walp <faceprint@faceprint.com> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #include "internal.h" #include "debug.h" #include "xmlnode.h" #include "jabber.h" #include "ping.h" #include "iq.h" void jabber_ping_parse(JabberStream *js, xmlnode *packet) { JabberIq *iq; purple_debug_info("jabber", "jabber_ping_parse\n"); iq = jabber_iq_new(js, JABBER_IQ_RESULT); xmlnode_set_attrib(iq->node, "to", xmlnode_get_attrib(packet, "from") ); jabber_iq_set_id(iq, xmlnode_get_attrib(packet, "id")); jabber_iq_send(iq); } static void jabber_ping_result_cb(JabberStream *js, xmlnode *packet, gpointer data) { const char *type = xmlnode_get_attrib(packet, "type"); purple_debug_info("jabber", "jabber_ping_result_cb\n"); if(type && !strcmp(type, "result")) { purple_debug_info("jabber", "PONG!\n"); } else { purple_debug_info("jabber", "(not supported)\n"); } } gboolean jabber_ping_jid(PurpleConversation *conv, const char *jid) { JabberIq *iq; xmlnode *ping; purple_debug_info("jabber", "jabber_ping_jid\n"); iq = jabber_iq_new(conv->account->gc->proto_data, JABBER_IQ_GET); xmlnode_set_attrib(iq->node, "to", jid); ping = xmlnode_new_child(iq->node, "ping"); xmlnode_set_namespace(ping, "urn:xmpp:ping"); jabber_iq_set_callback(iq, jabber_ping_result_cb, NULL); jabber_iq_send(iq); return TRUE; }