Mercurial > pidgin
view libpurple/dbus-maybe.h @ 32523:5e1250393e28
*** Plucked rev 950eb2e674f6da789c0132765c4f2d68ccd0d617 (markdoliner@pidgin.im):
Change the heuristic we use for setting od->icq. We used to set it to
true any time the username contained only digits. Now we set it to try
if account->protocol_id is prpl-icq. This means we're now relying on the
user to tell us whether their account is AIM or ICQ... and I think that's
fine.
The reason for this change is that we/AOL apparently allow the user to
login to ICQ accounts by entering their email address. This means we're
no longer able to look at the username to determine whether it's an AIM
name or an ICQ name.
This was a problem because we were trying to format the spacing/capitalization
in the username if the name was an icq email address, which resulted in
an annoying popup error at login. Fixes #13883.
It's probably safe for this to go into im.pidgin.pidgin (maybe after the
pending release), but I really don't want to keep changing the 2.x.y branch.
I think we need to move on to 3.x.y.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Sat, 18 Feb 2012 23:28:43 +0000 |
parents | 1568dc7a14f8 |
children |
line wrap: on
line source
/* This file contains macros that wrap calls to the purple dbus module. These macros call the appropriate functions if the build includes dbus support and do nothing otherwise. See "dbus-server.h" for documentation. */ #ifndef _PURPLE_DBUS_MAYBE_H_ #define _PURPLE_DBUS_MAYBE_H_ #ifdef HAVE_DBUS #ifndef DBUS_API_SUBJECT_TO_CHANGE #define DBUS_API_SUBJECT_TO_CHANGE #endif #include "dbus-server.h" /* this provides a type check */ #define PURPLE_DBUS_REGISTER_POINTER(ptr, type) { \ type *typed_ptr = ptr; \ purple_dbus_register_pointer(typed_ptr, PURPLE_DBUS_TYPE(type)); \ } #define PURPLE_DBUS_UNREGISTER_POINTER(ptr) purple_dbus_unregister_pointer(ptr) #else /* !HAVE_DBUS */ #define PURPLE_DBUS_REGISTER_POINTER(ptr, type) { \ if (ptr) {} \ } #define PURPLE_DBUS_UNREGISTER_POINTER(ptr) #define DBUS_EXPORT #endif /* HAVE_DBUS */ #endif