Mercurial > pidgin
view libpurple/protocols/bonjour/bonjour_ft.h @ 29685:6797736dbe37
Does anyone know the purpose of the ui_write, ui_read and data_not_sent
FT UI callbacks? It looks like they allow a UI to decide how to safe
incoming file transfers? They're not used in Pidgin or Finch. Are
they used elsewhere?
Valgrind is complaining about an invalid free. I think it happens either
when the local user cancels a file transfer or when the remote user
cancels a file transfer. I think this change fixes it.
Revision fa4ce539e5025eb07aad3ca824cd4c512010d8a8 is related to these
callbacks and to this change by foufou33@ gee male dot com
The valgrind error is:
==23064== Invalid free() / delete / delete[]
==23064== at 0x4C24D68: free (vg_replace_malloc.c:325)
==23064== by 0x9293209: g_array_free (in /lib/libglib-2.0.so.0.2200.3)
==23064== by 0x95B1995: purple_xfer_priv_data_destroy (ft.c:71)
==23064== by 0x92AA5D1: ??? (in /lib/libglib-2.0.so.0.2200.3)
==23064== by 0x92AAE17: g_hash_table_remove_all (in /lib/libglib-2.0.so.0.2200.3)
==23064== by 0x92AAFC4: g_hash_table_destroy (in /lib/libglib-2.0.so.0.2200.3)
==23064== by 0x95B579C: purple_xfers_uninit (ft.c:1642)
==23064== by 0x95ACF08: purple_core_quit (core.c:238)
==23064== by 0x43EB3E: gtk_blist_delete_cb (gtkblist.c:227)
==23064== by 0x6F9A727: ??? (in /usr/lib/libgtk-x11-2.0.so.0.1800.3)
==23064== Address 0x2355f0e0 is not stack'd, malloc'd or (recently) free'd
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Tue, 06 Apr 2010 09:52:27 +0000 |
parents | 7921a53b94b3 |
children |
line wrap: on
line source
/* * purple - Bonjour Protocol Plugin * * Purple is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA */ #ifndef _BONJOUR_FT_H_ #define _BONJOUR_FT_H_ #include "network.h" #include "proxy.h" typedef struct _XepXfer XepXfer; typedef enum { XEP_BYTESTREAMS = 1, XEP_IBB = 2, XEP_UNKNOWN = 4 } XepSiMode; struct _XepXfer { void *data; char *filename; int filesize; char *iq_id; char *sid; char *recv_id; char *buddy_ip; int mode; PurpleNetworkListenData *listen_data; int sock5_req_state; int rxlen; char rx_buf[0x500]; char tx_buf[0x500]; PurpleProxyInfo *proxy_info; PurpleProxyConnectData *proxy_connection; char *jid; char *proxy_host; int proxy_port; }; /** * Create a new PurpleXfer * * @param gc The PurpleConnection handle. * @param who Who will we be sending it to? */ PurpleXfer *bonjour_new_xfer(PurpleConnection *gc, const char *who); /** * Send a file. * * @param gc The PurpleConnection handle. * @param who Who are we sending it to? * @param file What file? If NULL, user will choose after this call. */ void bonjour_send_file(PurpleConnection *gc, const char *who, const char *file); void xep_si_parse(PurpleConnection *pc, xmlnode *packet, PurpleBuddy *pb); void xep_bytestreams_parse(PurpleConnection *pc, xmlnode *packet, PurpleBuddy *pb); #endif