Mercurial > pidgin
view libpurple/protocols/bonjour/buddy.h @ 29685:6797736dbe37
Does anyone know the purpose of the ui_write, ui_read and data_not_sent
FT UI callbacks? It looks like they allow a UI to decide how to safe
incoming file transfers? They're not used in Pidgin or Finch. Are
they used elsewhere?
Valgrind is complaining about an invalid free. I think it happens either
when the local user cancels a file transfer or when the remote user
cancels a file transfer. I think this change fixes it.
Revision fa4ce539e5025eb07aad3ca824cd4c512010d8a8 is related to these
callbacks and to this change by foufou33@ gee male dot com
The valgrind error is:
==23064== Invalid free() / delete / delete[]
==23064== at 0x4C24D68: free (vg_replace_malloc.c:325)
==23064== by 0x9293209: g_array_free (in /lib/libglib-2.0.so.0.2200.3)
==23064== by 0x95B1995: purple_xfer_priv_data_destroy (ft.c:71)
==23064== by 0x92AA5D1: ??? (in /lib/libglib-2.0.so.0.2200.3)
==23064== by 0x92AAE17: g_hash_table_remove_all (in /lib/libglib-2.0.so.0.2200.3)
==23064== by 0x92AAFC4: g_hash_table_destroy (in /lib/libglib-2.0.so.0.2200.3)
==23064== by 0x95B579C: purple_xfers_uninit (ft.c:1642)
==23064== by 0x95ACF08: purple_core_quit (core.c:238)
==23064== by 0x43EB3E: gtk_blist_delete_cb (gtkblist.c:227)
==23064== by 0x6F9A727: ??? (in /usr/lib/libgtk-x11-2.0.so.0.1800.3)
==23064== Address 0x2355f0e0 is not stack'd, malloc'd or (recently) free'd
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Tue, 06 Apr 2010 09:52:27 +0000 |
parents | d50194ab3016 |
children |
line wrap: on
line source
/* * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU Library General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301, USA. */ #ifndef _BONJOUR_BUDDY #define _BONJOUR_BUDDY #include <glib.h> #include "account.h" #include "jabber.h" typedef struct _BonjourBuddy { PurpleAccount *account; gchar *name; GSList *ips; gint port_p2pj; gchar *first; gchar *phsh; gchar *status; gchar *email; gchar *last; gchar *jid; gchar *AIM; gchar *vc; gchar *msg; gchar *ext; gchar *nick; gchar *node; gchar *ver; BonjourJabberConversation *conversation; gpointer mdns_impl_data; } BonjourBuddy; static const char *const buddy_TXT_records[] = { "1st", "email", "ext", "jid", "last", "msg", "nick", "node", "phsh", /* "port.p2pj", Deprecated - MUST ignore */ "status", /* "txtvers", Deprecated - hardcoded to 1 */ "vc", "ver", "AIM", /* non standard */ NULL }; /** * Creates a new buddy. */ BonjourBuddy *bonjour_buddy_new(const gchar *name, PurpleAccount *account); /** * Clear any existing values from the buddy. * This is called before updating so that we can notice removals */ void clear_bonjour_buddy_values(BonjourBuddy *buddy); /** * Sets a value in the BonjourBuddy struct, destroying the old value */ void set_bonjour_buddy_value(BonjourBuddy *buddy, const char *record_key, const char *value, guint32 len); /** * Check if all the compulsory buddy data is present. */ gboolean bonjour_buddy_check(BonjourBuddy *buddy); /** * If the buddy doesn't previously exists, it is created. Else, its data is changed (???) * purple_buddy is optional; it saves an additional lookup if we already have it */ void bonjour_buddy_add_to_purple(BonjourBuddy *bonjour_buddy, PurpleBuddy *purple_buddy); /** * The buddy has signed off Bonjour. * If the buddy is being saved, mark as offline, otherwise delete */ void bonjour_buddy_signed_off(PurpleBuddy *purple_buddy); /** * We got the buddy icon data; deal with it */ void bonjour_buddy_got_buddy_icon(BonjourBuddy *buddy, gconstpointer data, gsize len); /** * Deletes a buddy from memory. */ void bonjour_buddy_delete(BonjourBuddy *buddy); #endif