Mercurial > pidgin
view .mtn-ignore @ 30273:6829b27ee4c8
This patch attempts to fix four bugs in the oscar protocol plugin that
were introduced with the X-Status code in Pidgin 2.7.0.
Problem #1 (the remotely-triggerable crash):
The crash happens when a buddy sets an xstatus message containing <desc>
but no closing </desc>, or <title> but no closing </title>. The fix
is to check the result of strstr(closing_tag_name) and do nothing if it
is NULL. This is CVE-2010-2528.
Problem #2:
Fixes potential incorrect parsing of the xstatus string that could result
in an incorrect message being displayed to the libpurple user. Happens if
an xstatus message contains </desc> before <desc>, or </title> before
<title>. The fix is to start looking for the closing tag at the end
of the beginning tag rather than at the beginning of the xstatus xml.
Probably not a security problem, but definitely a bug.
Problem #3:
Fixes potential incorrect parsing of the xstatus string that could result
in the title not being shown to the libpurple user. Happens if the close
title tag appears after the desc tag in the xstatus xml, because we add a
null character at the beginning of the close title tag, so strstr() for
the desc tag would stop searching there. Probably not a security problem,
but definitely a bug.
Problem #4:
Fixes potential incorrect display of the xstatus string that could result
in an incorrect message being displayed to the libpurple user. Happens
because we reusing the 'xml' string when preparing the string for the user,
but we copy values from xml to xml. If those values overlap with themselves
or with each other then an incorrect value could be displayed. Probably not
a security problem, but definitely a bug.
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Wed, 21 Jul 2010 02:49:23 +0000 |
parents | 88a4a5a0fafa |
children | 1deda5d6733b |
line wrap: on
line source
(.*/)?\.svn .*/?Makefile(\.in)?$ .*/?Makefile\.am\.mingw$ (.*/)?TAGS$ .*/?.*\.pc$ .*/perl/common/[^/]+\.c$ .*/perl/common/blib.* .*/perl/common/pm_to_blib$ .*\.bs$ .*\.def$ .*\.dll$ .*\.exe$ .*\.loT$ intltool-.* Doxyfile(\.mingw)?$ aclocal.m4 autogen.args compile config.cache config.guess config.h$ config.h.in config.log config.status config.sub configure$ finch/finch$ finch/libgnt/gntmarshal.c finch/libgnt/gntmarshal.h depcomp doc/finch.1$ doc/pidgin.1$ doc/html package_revision.h package_revision_raw.txt pidgin.apspec$ pidgin.desktop$ pidgin.spec$ pidgin-.*.tar.gz pidgin-.*.tar.bz2 pidgin-*.*.*-dbgsym$ pidgin-*.*.*-dbgsym.zip$ pidgin-*.*.*-win32bin$ pidgin-*.*.*-win32-bin.zip$ pidgin/pidgin$ pidgin/pixmaps/emotes/default/24/theme pidgin/pixmaps/emotes/none/theme pidgin/pixmaps/emotes/small/16/theme pidgin/plugins/musicmessaging/music-messaging-bindings.c pidgin/plugins/perl/common/Makefile.PL$ pidgin/plugins/perl/common/Makefile.old pidgin/win32/pidgin_dll_rc.rc$ pidgin/win32/pidgin_exe_rc.rc$ pidgin/win32/nsis/gtk-runtime-*.*.*.*.zip pidgin/win32/nsis/gtk_runtime_stage$ pidgin/win32/nsis/pidgin-translations.nsh$ pidgin/win32/nsis/langmacros.nsh pidgin/win32/nsis/nsis_translations.desktop pidgin/win32/nsis/pidgin-spellcheck-preselect.nsh pidgin/win32/nsis/pidgin-spellcheck.nsh pidgin/win32/nsis/translations install-sh libpurple/dbus-bindings.c libpurple/dbus-signals.c libpurple/dbus-types.c libpurple/dbus-types.h libpurple/example/nullclient libpurple/gconf/purple.schemas$ libpurple/marshallers.[ch] libpurple/plugins/dbus-example-bindings.c libpurple/plugins/perl/common/Makefile.PL$ libpurple/plugins/perl/common/Makefile.old libpurple/plugins/perl/common/const-c.inc libpurple/plugins/perl/common/const-xs.inc libpurple/plugins/perl/common/lib libpurple/purple.h$ libpurple/purple-client-bindings.c libpurple/purple-client-bindings.h libpurple/purple-client-example libpurple/tests/check_libpurple libpurple/tests/libpurple.. libpurple/version.h$ libpurple/win32/libpurplerc.rc$ libtool local.mak ltmain.sh missing mkinstalldirs po/Makefile.in.in po/POTFILES$ po/missing po/notexist po/pidgin.pot po/stamp-it stamp-h1 win32-install-dir(\.release)? VERSION$