Mercurial > pidgin
view src/dnd-hints.h @ 7450:685736e14aac
[gaim-migrate @ 8061]
from bug #836143
-----------------------------------------------------------------
Date: 2003-11-06 17:19
Sender: zuperdee
Logged In: YES
user_id=347499
Alright folks, I HAVE A FIX!!!! I repeat, I HAVE A FIX!!!!!!!!!
Basically, this is what was wrong: the
account_win_destroy_cb function was failing to destroy the
window when the "window delete" event was happening.
I
reviewed the code, and it appears there are only 2 places
where that function is called, and in BOTH cases,
gtk_widget_destroy(dialog->window) was called before calling
account_win_destroy_cb. That's ugly!!!! So, my patch
rearranges things so gtk_widget_destroy is called at the
beginning of account_win_destroy_cb. That way, it *DOES*
destroy the window as it is supposed to, and it removes a
couple unnecessary lines of code. Woohoo!!!!!!!!!
I've tested it here on my own system, and it appears to
work, but I'd appreciate it if someone else could verify my
fix before it is checked in (should it be accepted).
The fix is in Patch #837542 here on Sourceforge. :-)
Yours Truly,
Daniel
(Yes, I am excited!!! I just fixed a problem in Gaim that
has been bugging me for some time. I *HATE* instability...
Call me the Segfault Avenger. ;-))
---------------------------------------------------------------
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Thu, 06 Nov 2003 23:29:40 +0000 |
parents | 4691c5936c01 |
children | fa6395637e2c |
line wrap: on
line source
/** * @file dnd-hints.h Drag-and-Drop arrow hints * @ingroup gtkui * * Copyright (C) 2002-2003, Christian Hammond <chipx86@gnupdate.org> * * Copyright (C) 2001 Ricardo Fernández Pascual * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2, or (at your option) * any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #ifndef _GAIM_DND_HINTS_H_ #define _GAIM_DND_HINTS_H_ #include <glib.h> #include <gtk/gtkwidget.h> /** * Conversation drag-and-drop arrow types. */ typedef enum { HINT_ARROW_UP, /**< Up arrow. */ HINT_ARROW_DOWN, /**< Down arrow. */ HINT_ARROW_LEFT, /**< Left arrow. */ HINT_ARROW_RIGHT /**< Right arrow. */ } DndHintWindowId; /** * Conversation drag-and-drop arrow positions. */ typedef enum { HINT_POSITION_RIGHT, /**< Position to the right of a tab. */ HINT_POSITION_LEFT, /**< Position to the left of a tab. */ HINT_POSITION_TOP, /**< Position above a tab. */ HINT_POSITION_BOTTOM, /**< Position below a tab. */ HINT_POSITION_CENTER /**< Position in the center of a tab. */ } DndHintPosition; /** * Shows a drag-and-drop hint at the specified location. * * @param id The ID of the hint to show. * @param x The X location to show it at. * @param y The Y location to show it at. */ void dnd_hints_show(DndHintWindowId id, gint x, gint y); /** * Hides the specified drag-and-drop hint. * * @param id The ID of the hint to hide. */ void dnd_hints_hide(DndHintWindowId id); /** * Hides all drag-and-drop hints. */ void dnd_hints_hide_all(void); /** * Shows a drag-and-drop hint relative to a widget. * * @param id The ID of the hint. * @param widget The widget that the hint is relative to. * @param horiz The horizontal relative position. * @param vert The vertical relative position. */ void dnd_hints_show_relative(DndHintWindowId id, GtkWidget *widget, DndHintPosition horiz, DndHintPosition vert); #endif /* _GAIM_DND_HINTS_H_ */