Mercurial > pidgin
view src/imgstore.h @ 7450:685736e14aac
[gaim-migrate @ 8061]
from bug #836143
-----------------------------------------------------------------
Date: 2003-11-06 17:19
Sender: zuperdee
Logged In: YES
user_id=347499
Alright folks, I HAVE A FIX!!!! I repeat, I HAVE A FIX!!!!!!!!!
Basically, this is what was wrong: the
account_win_destroy_cb function was failing to destroy the
window when the "window delete" event was happening.
I
reviewed the code, and it appears there are only 2 places
where that function is called, and in BOTH cases,
gtk_widget_destroy(dialog->window) was called before calling
account_win_destroy_cb. That's ugly!!!! So, my patch
rearranges things so gtk_widget_destroy is called at the
beginning of account_win_destroy_cb. That way, it *DOES*
destroy the window as it is supposed to, and it removes a
couple unnecessary lines of code. Woohoo!!!!!!!!!
I've tested it here on my own system, and it appears to
work, but I'd appreciate it if someone else could verify my
fix before it is checked in (should it be accepted).
The fix is in Patch #837542 here on Sourceforge. :-)
Yours Truly,
Daniel
(Yes, I am excited!!! I just fixed a problem in Gaim that
has been bugging me for some time. I *HATE* instability...
Call me the Segfault Avenger. ;-))
---------------------------------------------------------------
committer: Tailor Script <tailor@pidgin.im>
author | Luke Schierer <lschiere@pidgin.im> |
---|---|
date | Thu, 06 Nov 2003 23:29:40 +0000 |
parents | bf630f7dfdcd |
children | fa6395637e2c |
line wrap: on
line source
/** * @file imgstore.h IM Image Store API * @ingroup core * * gaim * * Copyright (C) 2003 Robert McQueen <robot101@debian.org> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA * */ #ifndef _GAIM_CONV_IMGSTORE_H_ #define _GAIM_CONV_IMGSTORE_H_ /** * Stored image * * Represents a single IM image awaiting display and/or transmission. */ typedef struct { char *data; /**< The image data. */ size_t size; /**< The image data's size. */ char *filename; /**< The filename (for the UI) */ } GaimStoredImage; #ifdef __cplusplus extern "C" { #endif /** * Add an image to the store. The caller owns a reference * to the image in the store, and must dereference the image * with gaim_imgstore_unref for it to be freed. * * @param data Pointer to the image data. * @param size Image data's size. * @param filename Filename associated with image. * @return ID for the image. */ int gaim_imgstore_add(const void *data, size_t size, const char *filename); /** * Retrieve an image from the store. The caller does not own a * reference to the image. * * @param id The ID for the image. * * @return A pointer to the requested image, or NULL if it was not found. */ GaimStoredImage *gaim_imgstore_get(int id); /** * Increment the reference count for an image in the store. The * image will be removed from the store when the reference count * is zero. * * @param id The ID for the image. */ void gaim_imgstore_ref(int id); /** * Decrement the reference count for an image in the store. The * image will be removed from the store when the reference count * is zero. * * @param id The ID for the image. */ void gaim_imgstore_unref(int id); #ifdef __cplusplus } #endif #endif /* _GAIM_CONV_IMGSTORE_H_ */