Mercurial > pidgin
view finch/gntrequest.h @ 31245:6b2b8cc8e7ae
OOH! I think I found the cause of a bug! I changed this function in revision
eadc83c534fbbc673a6876ddb1e0bdac8428c07b to try to make it cleaner. When I
did that, I added a break here when I should have added a continue. The result
is that if we encounter a non-utf8 name for an item in your server side buddy
list then we bail out earlier and don't add any server stored buddies to your
local list. That's bad. I think this caused a lot of people to not see their
complete buddy list. This probably affected ICQ users a lot more than AIM
users, because ICQ users tend to use more 3rd party IM clients, and 3rd party
IM clients sometimes put non-utf8 text in the name field of these items when
they shouldn't.
Hopefully fixes #13386
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Mon, 21 Feb 2011 09:45:47 +0000 |
parents | 829d054f4f1a |
children | 02a2e8183b1d |
line wrap: on
line source
/** * @file gntrequest.h GNT Request API * @ingroup finch */ /* finch * * Finch is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef _GNT_REQUEST_H #define _GNT_REQUEST_H #include "request.h" #include "gnt.h" /********************************************************************** * @name GNT Request API **********************************************************************/ /*@{*/ /** * Get the ui-functions. * * @return The PurpleRequestUiOps structure populated with the appropriate functions. */ PurpleRequestUiOps *finch_request_get_ui_ops(void); /** * Perform necessary initializations. */ void finch_request_init(void); /** * Perform necessary uninitializations. */ void finch_request_uninit(void); /** * Save the request fields in preferences where the id attribute of each field is the * id of a preference. */ void finch_request_save_in_prefs(gpointer null, PurpleRequestFields *fields); /** * Create a widget field for a request-field. * * @param field The request field. * * @return A GntWidget for the request field. * @since 2.4.0 */ GntWidget *finch_request_field_get_widget(PurpleRequestField *field); /*@}*/ #endif