Mercurial > pidgin
view libpurple/version.c @ 31245:6b2b8cc8e7ae
OOH! I think I found the cause of a bug! I changed this function in revision
eadc83c534fbbc673a6876ddb1e0bdac8428c07b to try to make it cleaner. When I
did that, I added a break here when I should have added a continue. The result
is that if we encounter a non-utf8 name for an item in your server side buddy
list then we bail out earlier and don't add any server stored buddies to your
local list. That's bad. I think this caused a lot of people to not see their
complete buddy list. This probably affected ICQ users a lot more than AIM
users, because ICQ users tend to use more 3rd party IM clients, and 3rd party
IM clients sometimes put non-utf8 text in the name field of these items when
they shouldn't.
Hopefully fixes #13386
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Mon, 21 Feb 2011 09:45:47 +0000 |
parents | 6bf32c9e15a7 |
children | eb2e2585f917 |
line wrap: on
line source
/* * @file version.c Version Functions * @ingroup core */ /* Purple is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #include "internal.h" #include "version.h" const guint purple_major_version = PURPLE_MAJOR_VERSION; const guint purple_minor_version = PURPLE_MINOR_VERSION; const guint purple_micro_version = PURPLE_MICRO_VERSION; const char *purple_version_check(guint required_major, guint required_minor, guint required_micro) { if (required_major > PURPLE_MAJOR_VERSION) return "libpurple version too old (major mismatch)"; if (required_major < PURPLE_MAJOR_VERSION) return "libpurple version too new (major mismatch)"; if (required_minor > PURPLE_MINOR_VERSION) return "libpurple version too old (minor mismatch)"; if ((required_minor == PURPLE_MINOR_VERSION) && (required_micro > PURPLE_MICRO_VERSION)) return "libpurple version too old (micro mismatch)"; return NULL; }