Mercurial > pidgin
view autogen.sh @ 14624:776615acf309
[gaim-migrate @ 17356]
After the comments on gaim-devel about 'bad' code, I looked into the function referenced. It appears that yahoo_buddy_icon_upload_connected() is only called as a callback. It's registered from yahoo_buddy_icon_upload(). yahoo_buddy_icon_upload() is only called twice. In neither case can a NULL make it down to yahoo_buddy_icon_upload_connected(). As this is an exceptional case rather than a normal one, a g_return_if_fail() is more appropriate. That adds logging, makes the intent clearer, and will help the Coverity software detect violations of this assumption.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Tue, 26 Sep 2006 17:38:09 +0000 |
parents | b4a5b77e167e |
children | c273952a004d |
line wrap: on
line source
#!/bin/sh (glib-gettextize --version) < /dev/null > /dev/null 2>&1 || { echo; echo "You must have glib-gettextize installed to compile Gaim."; echo; exit; } (intltoolize --version) < /dev/null > /dev/null 2>&1 || { echo; echo "You must have intltool installed to compile Gaim."; echo; exit; } (libtoolize --version) < /dev/null > /dev/null 2>&1 || { echo; echo "You must have libtool installed to compile Gaim."; echo; exit; } (automake --version) < /dev/null > /dev/null 2>&1 || { echo; echo "You must have automake installed to compile Gaim."; echo; exit; } (autoconf --version) < /dev/null > /dev/null 2>&1 || { echo; echo "You must have autoconf installed to compile Gaim."; echo; exit; } echo "Generating configuration files for Gaim, please wait...." echo; echo "Running libtoolize, please ignore non-fatal messages...." echo n | libtoolize --copy --force || exit; # Add other directories to this list if people continue to experience # brokennesses ... Obviously the real answer is for them to fix it # themselves, but for Luke's sake we have this. for dir in "/usr/local/share/aclocal" \ "/opt/gnome-1.4/share/aclocal" do if test -d $dir ; then ACLOCAL_FLAGS="$ACLOCAL_FLAGS -I $dir" fi done libtoolize -c -f --automake glib-gettextize --force --copy intltoolize --force --copy aclocal $ACLOCAL_FLAGS || exit; autoheader || exit; automake --add-missing --copy; autoconf || exit; automake || exit; ./configure $@