Mercurial > pidgin
view gaim.pc.in @ 14624:776615acf309
[gaim-migrate @ 17356]
After the comments on gaim-devel about 'bad' code, I looked into the function referenced. It appears that yahoo_buddy_icon_upload_connected() is only called as a callback. It's registered from yahoo_buddy_icon_upload(). yahoo_buddy_icon_upload() is only called twice. In neither case can a NULL make it down to yahoo_buddy_icon_upload_connected(). As this is an exceptional case rather than a normal one, a g_return_if_fail() is more appropriate. That adds logging, makes the intent clearer, and will help the Coverity software detect violations of this assumption.
committer: Tailor Script <tailor@pidgin.im>
| author | Richard Laager <rlaager@wiktel.com> |
|---|---|
| date | Tue, 26 Sep 2006 17:38:09 +0000 |
| parents | 009db0b357b5 |
| children | 32f954e8d8aa |
line wrap: on
line source
prefix=@prefix@ exec_prefix=@exec_prefix@ libdir=@libdir@ includedir=@includedir@ datadir=@datadir@ sysconfdir=@sysconfdir@ Name: Gaim Description: Gaim is a GTK2-based instant messenger application. Version: @VERSION@ Requires: glib-2.0 Cflags: -I${includedir}/gaim Libs: -L${libdir} -lgaim