Mercurial > pidgin
view libgaim/protocols/yahoo/.todo @ 14624:776615acf309
[gaim-migrate @ 17356]
After the comments on gaim-devel about 'bad' code, I looked into the function referenced. It appears that yahoo_buddy_icon_upload_connected() is only called as a callback. It's registered from yahoo_buddy_icon_upload(). yahoo_buddy_icon_upload() is only called twice. In neither case can a NULL make it down to yahoo_buddy_icon_upload_connected(). As this is an exceptional case rather than a normal one, a g_return_if_fail() is more appropriate. That adds logging, makes the intent clearer, and will help the Coverity software detect violations of this assumption.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Tue, 26 Sep 2006 17:38:09 +0000 |
parents | 60b1bc8dbf37 |
children |
line wrap: on
line source
<todo version="0.1.19"> <note priority="high" time="1036976065" done="1129563169"> offline messages get lost, esp. if more than 1 sent (is this fixed?) <comment> I've not heard a report on this for some time </comment> </note> <note priority="medium" time="1036041356" done="1061347647"> color <comment> patch is in, but it doesn't do bg colors right currently and doesn't do default colors </comment> <note priority="high" time="1036041423"> <fade> tags need parsed. </note> </note> <note priority="medium" time="1036041385" done="1061347733"> display profile <comment> this is as done as it is likely to get any time soon </comment> </note> <note priority="high" time="1036041328"> bug: won't allow me to delete myself from my list past sign on </note> <note priority="medium" time="1036041395"> make away message display like that of aim/icq/jabber </note> <note priority="medium" time="1036041400"> auto reply on away </note> <note priority="verylow" time="1036041308"> web cam support </note> <note priority="verylow" time="1036041449"> voice chat </note> </todo>