Mercurial > pidgin
view libgaim/protocols/yahoo/Makefile.am @ 14624:776615acf309
[gaim-migrate @ 17356]
After the comments on gaim-devel about 'bad' code, I looked into the function referenced. It appears that yahoo_buddy_icon_upload_connected() is only called as a callback. It's registered from yahoo_buddy_icon_upload(). yahoo_buddy_icon_upload() is only called twice. In neither case can a NULL make it down to yahoo_buddy_icon_upload_connected(). As this is an exceptional case rather than a normal one, a g_return_if_fail() is more appropriate. That adds logging, makes the intent clearer, and will help the Coverity software detect violations of this assumption.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Tue, 26 Sep 2006 17:38:09 +0000 |
parents | 60b1bc8dbf37 |
children | 69590c55c748 |
line wrap: on
line source
EXTRA_DIST = \ Makefile.mingw pkgdir = $(libdir)/gaim YAHOOSOURCES = \ util.c \ yahoo.c \ yahoo.h \ yahoochat.h \ yahoochat.c \ yahoo_auth.c \ yahoo_auth.h \ yahoo_crypt.h \ yahoo_crypt.c \ yahoo_doodle.h \ yahoo_doodle.c \ yahoo_filexfer.h \ yahoo_filexfer.c \ yahoo_friend.h \ yahoo_friend.c \ yahoo_packet.h \ yahoo_packet.c \ yahoo_picture.c \ yahoo_picture.h \ yahoo_profile.c \ ycht.c \ ycht.h AM_CFLAGS = $(st) libyahoo_la_LDFLAGS = -module -avoid-version $(GLIB_LIBS) if STATIC_YAHOO st = -DGAIM_STATIC_PRPL noinst_LIBRARIES = libyahoo.a libyahoo_a_SOURCES = $(YAHOOSOURCES) libyahoo_a_CFLAGS = $(AM_CFLAGS) else st = pkg_LTLIBRARIES = libyahoo.la libyahoo_la_SOURCES = $(YAHOOSOURCES) endif AM_CPPFLAGS = \ -I$(top_srcdir)/libgaim \ $(GLIB_CFLAGS) \ $(DEBUG_CFLAGS)