Mercurial > pidgin
view libgaim/protocols/yahoo/yahoo_auth.h @ 14624:776615acf309
[gaim-migrate @ 17356]
After the comments on gaim-devel about 'bad' code, I looked into the function referenced. It appears that yahoo_buddy_icon_upload_connected() is only called as a callback. It's registered from yahoo_buddy_icon_upload(). yahoo_buddy_icon_upload() is only called twice. In neither case can a NULL make it down to yahoo_buddy_icon_upload_connected(). As this is an exceptional case rather than a normal one, a g_return_if_fail() is more appropriate. That adds logging, makes the intent clearer, and will help the Coverity software detect violations of this assumption.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Tue, 26 Sep 2006 17:38:09 +0000 |
parents | 60b1bc8dbf37 |
children |
line wrap: on
line source
/* * yahoo_auth.h: Header for Yahoo Messenger authentication schemes. Eew. * * Copyright(c) 2003 Cerulean Studios */ #ifndef _YAHOO_AUTH_H_ #define _YAHOO_AUTH_H_ #define NUM_TYPE_THREES 105 #define NUM_TYPE_FOURS 56 #define NUM_TYPE_FIVES 37 unsigned int yahoo_auth_finalCountdown(unsigned int challenge, int divisor, int inner_loop, int outer_loop); /* We've defined the Yahoo authentication functions as having types 1-5; all take either 1 or 2 arguments. */ typedef struct _auth { int type; int var1; int var2; } auth_function_t; /* Type 3, 4 and 5 require lookups into ypager.exe's many static chunks of 256 bytes. Store them here. */ struct buffer_t { unsigned int buffer_start; unsigned char buffer[257]; }; #endif /* _YAHOO_AUTH_H_ */