Mercurial > pidgin
view Makefile.am @ 32146:88a46649de3d
Remove a bogus short-circuit check intended to prevent downloading the same icon
every time a buddy logs in. There are three problems with the check:
* The fact that we already have an icon for the buddy doesn't mean it hasn't
changed on the server since we last downloaded.
* We should really be checking against the server-provided checksum, but we
don't know how to checksum the same way the server does.
* We no longer receive a checksum at the YMSG protocol level, so we'd have to
parse such a checksum out of the picture URL, which is going to be fragile
and seems just plain stupid to me.
It seems better to me all around to just axe the check and potentially waste
some bandwidth. If someone wants to figure out a bandwidth-saving fix for this,
feel free.
At any rate, this fixes #13050.
author | John Bailey <rekkanoryo@rekkanoryo.org> |
---|---|
date | Sun, 11 Sep 2011 04:18:46 +0000 |
parents | 6f3df8fc3037 |
children | ade9644db2fe |
line wrap: on
line source
EXTRA_DIST = \ COPYRIGHT \ ChangeLog.API \ ChangeLog.win32 \ Doxyfile.in \ HACKING \ Makefile.mingw \ PLUGIN_HOWTO \ README.MTN \ README.mingw \ config.h.mingw \ doxy2devhelp.xsl \ fix-casts.sh \ gaim.pc.in \ gaim-uninstalled.pc.in \ intltool-extract.in \ intltool-merge.in \ intltool-update.in \ package_revision.h \ pidgin.apspec.in \ pidgin.spec.in \ pidgin.desktop.in \ po/Makefile.mingw \ valgrind-suppressions noinst_HEADERS = config.h package_revision.h dist-hook: pidgin.spec cp pidgin.spec $(distdir) rm $(distdir)/config.h distcheck-hook: libpurple/plugins/perl/common/Purple.pm pidgin/plugins/perl/common/Pidgin.pm # cp libpurple/plugins/perl/common/Gaim.pm $(distdir)/libpurple/plugins/perl/common commit-check: (cd po ; intltool-update -m 2>&1 | grep -v '^mismatched quotes.*\.py$$' | sed "s|current directory|po directory|" | grep . ; if [ $$? = 0 ] ; then exit 1 ; else exit 0 ; fi) LC_ALL=C sort -c -t/ -u po/POTFILES.in LC_ALL=C sort -c -t/ -u po/POTFILES.skip iconv -f utf8 -t utf8 COPYRIGHT | cmp COPYRIGHT - version-check: commit-check # We don't want to release development versions. test x`echo $(PACKAGE_VERSION) | grep dev` = x # When doing a new minor (or major) release (X.Y.0), there must be a section in # ChangeLog.API. echo $(PACKAGE_VERSION) | grep -v "^[0-9]\+\.[0-9]\+\.0$$" >/dev/null || head ChangeLog.API | grep "^version $(PACKAGE_VERSION) (`date +%m/%d/%Y`):$$" >/dev/null # For all releases, check the ChangeLogs. head ChangeLog | grep "^version $(PACKAGE_VERSION) (`date +%m/%d/%Y`):$$" >/dev/null head po/ChangeLog | grep "^version $(PACKAGE_VERSION)$$" >/dev/null # Ensure we're working from a tag... test x`mtn automate select t:v$(PACKAGE_VERSION)` = x`mtn automate get_base_revision_id` # ... and have no changes in the working copy. test "x`mtn diff | grep -v '^#'`" = x release: version-check distcheck packages packages: gpg -ab pidgin-$(PACKAGE_VERSION).tar.gz gpg -ab pidgin-$(PACKAGE_VERSION).tar.bz2 gpg --verify pidgin-$(PACKAGE_VERSION).tar.gz.asc pidgin-$(PACKAGE_VERSION).tar.gz gpg --verify pidgin-$(PACKAGE_VERSION).tar.bz2.asc pidgin-$(PACKAGE_VERSION).tar.bz2 if INSTALL_I18N PO_DIR=po DESKTOP_FILE=pidgin.desktop if ENABLE_GTK appsdir = $(datadir)/applications apps_in_files = pidgin.desktop.in apps_DATA = $(apps_in_files:.desktop.in=.desktop) @INTLTOOL_DESKTOP_RULE@ endif #ENABLE_GTK endif #INSTALL_I18N if ENABLE_GTK GTK_DIR=pidgin endif if ENABLE_GNT GNT_DIR=finch endif # This is phony, so that we always try to rebuild it. If it succeeds # in calculating changes, it produces its target; otherwise, its # target does not exist. .PHONY: package_revision_raw.txt # if both attempts fail, then we need to remove the empty file that > # creates, and also make sure that the shell command exits # successfully; the rm -f ensures both package_revision_raw.txt: $(AM_V_GEN)REAL_BLDDIR=$$PWD/$(top_builddir); \ (cd $(srcdir) && $$REAL_BLDDIR/mtn --root=. automate get_base_revision_id) 2>/dev/null >$@ \ || (cd $(srcdir) && mtn --root=. automate get_base_revision_id) 2>/dev/null >$@ \ || rm -f $@ package_revision.h: package_revision_raw.txt $(AM_V_GEN)if test -f $<; then \ echo "#define REVISION \"`cat $<`\"" > $@; \ fi $(AM_V_at)if test ! -f $@ -a -f $(srcdir)/$@; then \ cp $(srcdir)/$@ $@; \ fi $(AM_V_at)test -f $@ || echo "#define REVISION \"unknown\"" > $@ # This is a magic directive copy-and-pasted, then modified, from the # automake 1.9 manual, section 13.4, "Checking the distribution". # Normally, 'distcheck' does a clean build, and then afterwards runs # 'distclean', and 'distclean' is supposed to remove everything that # the build created. However, we have some targets (package_revision.txt) # that we distribute, but then always attempt to rebuild optimistically, and # then if that fails fall back on the distributed versions. This # means that 'distclean' should _not_ remove those files, since they # are distributed, yet building the package will generate those files, # thus automake thinks that 'distclean' _should_ remove those files, # and 'distcheck' gets cranky if we don't. So basically what this # line does is tell 'distcheck' to shut up and ignore those two files. distcleancheck_listfiles = find . -type f -a ! -name package_revision.h SUBDIRS = . libpurple doc $(GNT_DIR) $(GTK_DIR) m4macros $(PO_DIR) share/ca-certs share/sounds docs: Doxyfile if HAVE_DOXYGEN @echo "Running doxygen..." @doxygen if HAVE_XSLTPROC @echo "Generating devhelp index..." @xsltproc $(top_srcdir)/doxy2devhelp.xsl doc/xml/index.xml > doc/html/pidgin.devhelp @echo "(Symlink $$(pwd)/doc/html to ~/.local/share/gtk-doc/html/pidgin to make devhelp see the documentation)" else @echo "Not generating devhelp index: xsltproc was not found by configure" endif else @echo "doxygen was not found during configure. Unable to build documentation." @echo; endif # perl's MakeMaker uninstall foo doesn't work well with DESTDIR set, which # breaks "make distcheck" unless we ignore perl things distuninstallcheck_listfiles = \ find . -type f -print | grep -v perl | grep -v Purple.3pm DISTCLEANFILES= $(DESKTOP_FILE) libpurple/gconf/purple.schemas intltool-extract \ intltool-merge intltool-update