Mercurial > pidgin
view finch/gntaccount.h @ 32146:88a46649de3d
Remove a bogus short-circuit check intended to prevent downloading the same icon
every time a buddy logs in. There are three problems with the check:
* The fact that we already have an icon for the buddy doesn't mean it hasn't
changed on the server since we last downloaded.
* We should really be checking against the server-provided checksum, but we
don't know how to checksum the same way the server does.
* We no longer receive a checksum at the YMSG protocol level, so we'd have to
parse such a checksum out of the picture URL, which is going to be fragile
and seems just plain stupid to me.
It seems better to me all around to just axe the check and potentially waste
some bandwidth. If someone wants to figure out a bandwidth-saving fix for this,
feel free.
At any rate, this fixes #13050.
author | John Bailey <rekkanoryo@rekkanoryo.org> |
---|---|
date | Sun, 11 Sep 2011 04:18:46 +0000 |
parents | acf284962b40 |
children | 02a2e8183b1d |
line wrap: on
line source
/** * @file gntaccount.h GNT Account API * @ingroup finch */ /* finch * * Finch is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02111-1301 USA */ #ifndef _GNT_ACCOUNT_H #define _GNT_ACCOUNT_H #include "account.h" /********************************************************************** * @name GNT Account API **********************************************************************/ /*@{*/ /** * Get the ui-functions. * * @return The PurpleAccountUiOps structure populated with the appropriate functions. */ PurpleAccountUiOps *finch_accounts_get_ui_ops(void); /** * Perform necessary initializations. */ void finch_accounts_init(void); /** * Perform necessary uninitializations. */ void finch_accounts_uninit(void); /** * Show the account-manager dialog. */ void finch_accounts_show_all(void); /** * Show the edit dialog for an account. * * @param account The account to edit, or @c NULL to create a new account. * * @since 2.2.0 */ void finch_account_dialog_show(PurpleAccount *account); /*@}*/ #endif