Mercurial > pidgin
view src/protocols/zephyr/ZSendPkt.c @ 11044:8bf376579177
[gaim-migrate @ 12958]
Patch #1229320 from Bleeter
"I couldn't get anyone to confirm that doing this is correct, however to me it would seem that I'm leaking on a couple of the privacy_checks inside the yahoo prpl. Here's a fix. This also includes privacy wrapper for the conference decline function, used in some booters."
(00:37:39) Bleeter: ... we're returning out of the function, and those things are freed further down if the function isn't returned
(00:38:18) Bleeter: so it makes sense to free them before the return. I'm just unsure because they'reprevious patches which were applied without these checks being picked up
That makes sense to me. It looks good.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Thu, 30 Jun 2005 05:41:43 +0000 |
parents | 5727afad0fb8 |
children | 64895571248f |
line wrap: on
line source
/* This file is part of the Project Athena Zephyr Notification System. * It contains source for the ZSendPacket function. * * Created by: Robert French * * $Source$ * $Author: thekingant $ * * Copyright (c) 1987,1991 by the Massachusetts Institute of Technology. * For copying and distribution information, see the file * "mit-copyright.h". */ /* $Header$ */ #ifndef lint static char rcsid_ZSendPacket_c[] = "$Zephyr: /mit/zephyr/src/lib/RCS/ZSendPacket.c,v 1.29 91/03/21 11:57:08 raeburn Exp $"; #endif #include "internal.h" #ifdef WIN32 #include <winsock.h> #else #include <sys/socket.h> #endif static int wait_for_hmack(); Code_t ZSendPacket(packet, len, waitforack) char *packet; int len; int waitforack; { Code_t retval; struct sockaddr_in dest; ZNotice_t notice, acknotice; if (!packet || len < 0) return (ZERR_ILLVAL); if (len > Z_MAXPKTLEN) return (ZERR_PKTLEN); if (ZGetFD() < 0) if ((retval = ZOpenPort((unsigned short *)0)) != ZERR_NONE) return (retval); dest = ZGetDestAddr(); if (sendto(ZGetFD(), packet, len, 0, (struct sockaddr *)&dest, sizeof(dest)) < 0) return (errno); if (!waitforack) return (ZERR_NONE); if ((retval = ZParseNotice(packet, len, ¬ice)) != ZERR_NONE) return (retval); retval = Z_WaitForNotice (&acknotice, wait_for_hmack, ¬ice.z_uid, HM_TIMEOUT); if (retval == ETIMEDOUT) return ZERR_HMDEAD; if (retval == ZERR_NONE) ZFreeNotice (&acknotice); return retval; } static int wait_for_hmack(notice, uid) ZNotice_t *notice; ZUnique_Id_t *uid; { return (notice->z_kind == HMACK && ZCompareUID(¬ice->z_uid, uid)); }