Mercurial > pidgin
view PROGRAMMING_NOTES @ 13666:915f26ce1d07
[gaim-migrate @ 16068]
Suppress CID 108.
Event assign_zero: Variable "(irc)->roomlist" assigned value 0.
278 irc->roomlist = NULL;
Event var_deref_model: Variable "(irc)->roomlist" tracked as NULL was passed to a function that dereferences it.
288 gaim_roomlist_room_add_field(irc->roomlist, room, args[1]);
nosnilmot noted:
'name can't be both "323" and "322" at the same time, so this will never happen'
In the 323 case, this saves us a strcmp() that we know is useless, and adding the return is consistent with the 321 block above.
committer: Tailor Script <tailor@pidgin.im>
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Thu, 20 Apr 2006 04:56:44 +0000 |
parents | da88e2cd5c53 |
children | 83ec0b408926 |
line wrap: on
line source
Notes on keeping GAIM OS independant ------------------------------------ General ------- - Use G_DIR_SEPARATOR_S and G_DIR_SEPARATOR for paths - Use g_getenv, g_snprintf, g_vsnprintf - Use gaim_home_dir instead of g_get_home_dir or g_getenv("HOME") - Make sure when including win32dep.h that it is the last header to be included. - Open binary files when reading or writing with 'b' mode. e.g: fopen("somefile", "wb"); Not doing so will open files in windows using defaut translation mode. i.e. newline -> <CR><LF> Paths ----- - DATADIR, LOCALEDIR & LIBDIR are defined in wingaim as functions. Doing the following will therefore break the windows build: printf("File in DATADIR is: %s\n", DATADIR G_DIR_SEPARATOR_S "pic.png"); it should be: printf("File in DATADIR is: %s%s%s\n", DATADIR, G_DIR_SEPARATOR_S, "pic.png"); PLUGINS & PROTOS ---------------- - G_MODULE_EXPORT all functions which are to be accessed from outside the scope of its "dll" or "so". (E.G. gaim_plugin_init) - G_MODULE_IMPORT all global variables which are located outside your dynamic library. (E.G. connections) (Not doing this will cause "Memory Access Violations" in Win32)