view .mtn-ignore @ 16569:99bf55ec6ca4

Fix an invalid read that occurs because we were accessing IM data when the conversation was a chat. Here's the relevant valgrind output. ==18344== Invalid read of size 4 ==18344== at 0x8089DA1: update_typing_icon (gtkconv.c:3138) ==18344== by 0x8090742: pidgin_conv_update_fields (gtkconv.c:6081) ... ==18344== Address 0x107EADD0 is 12 bytes after a block of size 12 alloc'd ==18344== at 0x40056D5: calloc (vg_replace_malloc.c:279) ==18344== by 0x4D48EC4D: g_malloc0 (in /usr/lib/libglib-2.0.so.0.1200.4) ==18344== by 0x809149B: private_gtkconv_new (gtkconv.c:4608) ==18344== by 0x4056637: purple_conversation_new (conversation.c:324) ==18344== by 0x40785EB: serv_got_joined_chat (server.c:699) ==18344== by 0x493C813: irc_msg_join (msgs.c:722) ...
author Richard Laager <rlaager@wiktel.com>
date Sat, 28 Apr 2007 05:37:56 +0000
parents 93f1801d4cc6
children 56c61eb40850
line wrap: on
line source

.*/?Makefile(\.in)?$
(.*/)?TAGS$
.*/?.*\.pc$
.*/perl/common/[^/]+\.c$
.*/perl/common/blib.*
.*/perl/common/pm_to_blib$
.*\.bs$
.*\.dll$
.*\.exe$
intltool-.*
Doxyfile$
aclocal.m4
compile
config.guess
config.h$
config.h.in
config.log
config.status
config.sub
configure$
finch/finch
finch/libgnt/gntmarshal.c
finch/libgnt/gntmarshal.h
depcomp
doc/finch.1$
doc/pidgin.1$
doc/html
pidgin.apspec$
pidgin.desktop$
pidgin.spec$
pidgin-.*.tar.gz
pidgin-.*.tar.bz2
pidgin/pidgin
pidgin/plugins/musicmessaging/music-messaging-bindings.c
pidgin/plugins/perl/common/Makefile.PL$
pidgin/win32/pidgin_dll_rc.rc$
pidgin/win32/pidgin_exe_rc.rc$
install-sh
libpurple/dbus-bindings.c
libpurple/dbus-types.c
libpurple/dbus-types.h
libpurple/example/nullclient
libpurple/gconf/purple.schemas$
libpurple/plugins/dbus-example-bindings.c
libpurple/plugins/perl/common/Makefile.PL$
libpurple/plugins/perl/common/const-c.inc
libpurple/plugins/perl/common/const-xs.inc
libpurple/plugins/perl/common/lib
libpurple/purple-client-bindings.c
libpurple/purple-client-bindings.h
libpurple/purple-client-example
libpurple/tests/check_libpurple
libpurple/win32/libpurplerc.rc$
libtool
local.mak
ltmain.sh
missing
mkinstalldirs
po/Makefile.in.in
po/POTFILES$
po/missing
po/notexist
po/pidgin.pot
po/stamp-it
stamp-h1
win32-install-dir(\.release)?
VERSION$