Mercurial > pidgin
view finch/gntconv.h @ 16569:99bf55ec6ca4
Fix an invalid read that occurs because we were accessing IM data when the
conversation was a chat.
Here's the relevant valgrind output.
==18344== Invalid read of size 4
==18344== at 0x8089DA1: update_typing_icon (gtkconv.c:3138)
==18344== by 0x8090742: pidgin_conv_update_fields (gtkconv.c:6081)
...
==18344== Address 0x107EADD0 is 12 bytes after a block of size 12 alloc'd
==18344== at 0x40056D5: calloc (vg_replace_malloc.c:279)
==18344== by 0x4D48EC4D: g_malloc0 (in /usr/lib/libglib-2.0.so.0.1200.4)
==18344== by 0x809149B: private_gtkconv_new (gtkconv.c:4608)
==18344== by 0x4056637: purple_conversation_new (conversation.c:324)
==18344== by 0x40785EB: serv_got_joined_chat (server.c:699)
==18344== by 0x493C813: irc_msg_join (msgs.c:722)
...
author | Richard Laager <rlaager@wiktel.com> |
---|---|
date | Sat, 28 Apr 2007 05:37:56 +0000 |
parents | 0f0832c13fcb |
children | 5e6f8b92a2a5 |
line wrap: on
line source
/** * @file gntconv.h GNT Conversation API * @ingroup finch * * finch * * Finch is the legal property of its developers, whose names are too numerous * to list here. Please refer to the COPYRIGHT file distributed with this * source distribution. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the * GNU General Public License for more details. * * You should have received a copy of the GNU General Public License * along with this program; if not, write to the Free Software * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA */ #ifndef _GNT_CONV_H #define _GNT_CONV_H #include <gnt.h> #include <gntwidget.h> #include "conversation.h" /*************************************************************************** * @name GNT Conversations API ***************************************************************************/ /*@{*/ typedef struct _FinchConv FinchConv; typedef struct _FinchConvChat FinchConvChat; typedef struct _FinchConvIm FinchConvIm; struct _FinchConv { GList *list; PurpleConversation *active_conv; GntWidget *window; /* the container */ GntWidget *entry; /* entry */ GntWidget *tv; /* text-view */ GntWidget *menu; /* future use */ GntWidget *info; union { FinchConvChat *chat; FinchConvIm *im; } u; }; struct _FinchConvChat { GntWidget *userlist; /* the userlist */ }; struct _FinchConvIm { void *nothing_for_now; }; /** * Get the ui-functions. * * @return The PurpleConversationUiOps populated with the appropriate functions. */ PurpleConversationUiOps *finch_conv_get_ui_ops(void); /** * Perform the necessary initializations. */ void finch_conversation_init(void); /** * Perform the necessary uninitializations. */ void finch_conversation_uninit(void); /** * Set a conversation as active in a contactized conversation * * @param conv The conversation to make active. */ void finch_conversation_set_active(PurpleConversation *conv); /** * Sets the information widget for the conversation window. * * @param conv The conversation. * @param widget The widget containing the information. If @c NULL, * the current information widget is removed. */ void finch_conversation_set_info_widget(PurpleConversation *conv, GntWidget *widget); /*@}*/ #endif