Mercurial > pidgin
view libpurple/protocols/myspace/ChangeLog @ 20982:aee8d876fed1
When getting info on a myspace user not on the buddy list, a temporary
PurpleBuddy is needed so that the data can be associated properly. This
fixes a bug wherein the profile link went to http://myspace.com/0 for all
buddies not on the list. A check against that uid being 0 has also been added
to avoid displaying junk data.
Such temporary MsimUser objects (note that the temporariness of MsimUser
objects is unchanged; a temporary PurpleBuddy has just been added to go with
it) are destroyed before a delayed callback can be triggerred. This means that
we can not request a buddy icon on that object, because we will end up with
a pointer to freed data in the callback some time in the future. This fixes
a crash when getting info on a non-buddy list buddy (which for reasons I can't
pinpoint was most likely if the username contained capital letters).
A reference counting system for MsimUser objects would fix this but is a
significantly more complex solution.
author | Evan Schoenberg <evan.s@dreskin.net> |
---|---|
date | Thu, 18 Oct 2007 12:01:41 +0000 |
parents | d87916bd1d73 |
children |
line wrap: on
line source
2007-04-29 Jeff Connelly <jeff2@soc.pidgin.com> * NOTE: This code is now being developed under Monotone, in the im.pidgin.soc.2007.msimprpl branch on my local computer, which is periodically sync'd with pidgin.im's Monotone database. Changes will be logged to Monotone. 2007-04-15 Jeff Connelly <myspaceim@xyzzy.cjb.net> - 0.4 * Gracefully handle a full receive buffer * Handle fatal errors 2007-04-14 Jeff Connelly <myspaceim@xyzzy.cjb.net> - 0.3 * Win32 support * Add a large number of precondition checks and a handful of assertions * Add documentation to each function, for doxygen. 2007-04-10 Jeff Connelly <myspaceim@xyzzy.cjb.net> - 0.2 * Add ability to IM by email address. * Show usernames on buddy list instead of userids. * Show incoming messages as coming from username, instead of userid. * Add status messages and tooltip text. 2007-04-09 Jeff Connelly <myspaceim@xyzzy.cjb.net> - 0.1 * Parsing most of the protocol. * Logging in using RC4/SHA1-based authentication. * Sending messages, by numeric userid or username. * Receiving messages, currently only by numeric userid. * Some buddy list support (show all users on buddy list as online, by uid). 2007-04-07 Jeff Connelly <myspaceim@xyzzy.cjb.net> - 0.0 * Initial version. Login only. Not publicly released.