Mercurial > pidgin
view src/dbus-useful.c @ 13654:b6f7686c6082
[gaim-migrate @ 16056]
Fix Coverity CID 28: Fix some checks so that a function
isn't ugly.
Fix Coverity CID 76, 77 and 112: Get rid of an unnecessary
NULL-pointer check after we'd already dereferenced
a pointer.
Fix Coverity CID 124: Possible use of a NULL pointer in
gaim_icon_parseicon. It only had the potential to crash
when compiled with g_assertions turned off.
Fix Coverity CID 125: Possible use of a NULL pointer in
gaim_parse_oncoming. It only had the potential to crash
when compiled with g_assertions turned off.
Fix Coverity CID 123 and 136: Possible dereference of a
NULL pointer in gaim_auth_request(). It was only possible
when you turned off g_assertions, and even then I'm not so
sure. In any case, the code is certainly cleaner now.
committer: Tailor Script <tailor@pidgin.im>
author | Mark Doliner <mark@kingant.net> |
---|---|
date | Tue, 18 Apr 2006 05:48:07 +0000 |
parents | c9312177821a |
children | 8bda65b88e49 |
line wrap: on
line source
#include <string.h> #include <glib.h> #include "dbus-useful.h" #include "conversation.h" #include "util.h" GaimAccount * gaim_accounts_find_ext(const char *name, const char *protocol_id, gboolean (*account_test)(const GaimAccount *account)) { GaimAccount *result = NULL; GList *l; char *who; if (name) who = g_strdup(gaim_normalize(NULL, name)); else who = NULL; for (l = gaim_accounts_get_all(); l != NULL; l = l->next) { GaimAccount *account = (GaimAccount *)l->data; if (who && strcmp(gaim_normalize(NULL, gaim_account_get_username(account)), who)) continue; if (protocol_id && strcmp(account->protocol_id, protocol_id)) continue; if (account_test && !account_test(account)) continue; result = account; break; } g_free(who); return result; } GaimAccount *gaim_accounts_find_any(const char *name, const char *protocol) { return gaim_accounts_find_ext(name, protocol, NULL); } GaimAccount *gaim_accounts_find_connected(const char *name, const char *protocol) { return gaim_accounts_find_ext(name, protocol, gaim_account_is_connected); }